Switch to verbose logs by default
ClosedPublic
Actions

Authored by AMDmi3 on Aug 16 2016, 4:43 PM.

Details

Reviewers

None

Group Reviewers

O5: Ports Framework	(Owns No Changed Paths)
portmgr

Commits

rP421635: Most commonly used build systems support silent builds, when they

Summary

See https://reviews.freebsd.org/D7533 for related PHB change.

Some ports build silently, hiding executed commands under non-informative summary, such as

CC     source1.o
CC     source2.o
CCLD   someprogram

This is unacceptable as build logs are crucial to debugging port
build problems both on the cluster and based on end user feedback
and also global mining of build problems such as non-respected
C(XX)FLAGS and incorrect -I/-L ordering.

Mention the policy in CHANGES and enable verbose logs for cmake and ninja.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 5107
Build 5199: arc lint + arc unit

Event Timeline

AMDmi3 updated this revision to Diff 19361.Aug 16 2016, 4:43 PM

AMDmi3 retitled this revision from to Switch to verbose logs by default.

AMDmi3 updated this object.

AMDmi3 edited the test plan for this revision. (Show Details)

Owners added a reviewer: O5: Ports Framework.Aug 16 2016, 4:43 PM

Herald added a reviewer: portmgr. · View Herald TranscriptAug 16 2016, 4:43 PM

Herald added a subscriber: mat. · View Herald Transcript

AMDmi3 added a parent revision: D7533: Introduce policy of preferring verbose logs.Aug 16 2016, 4:44 PM

You left our autoconf builds. Were you going to look at that too?

I agree with this but I wonder if we should just flip to the opposite, meaning adding a NINJA_QUIET and CMAKE_QUIET rather than forcing 100% verbose.

You talk about GNU_CONFIGURE ports, but then you fix cmake and ninja, did you forget some bit of patch there?

In D7534#156659, @bdrewery wrote:

You left our autoconf builds. Were you going to look at that too?

As suggested by mandree@ on #bsdports, it's not cleanly possible. Not all configure scripts support --disable-silent-rules, not all generated makefiles support V=1 env, and this variable may have different meaning so we may not set --disable-silent-rules or V=1 globally. Instead, I suggest to add CONFIGURE_ARGS+=--disable-silent-rules to individual ports which use silent builds.

I agree with this but I wonder if we should just flip to the opposite, meaning adding a NINJA_QUIET and CMAKE_QUIET rather than forcing 100% verbose.

I've though of it, but only a tiny fraction of ports will support QUIET option, only a tiny fraction of users will use it, so it's not worth the maintainance cost and basically useless. And there are chances that some port will break for user who set QUIET and valuable information will be lost making investigation harder.

In D7534#156677, @mat wrote:

You talk about GNU_CONFIGURE ports, but then you fix cmake and ninja, did you forget some bit of patch there?

No I didn't. These will be fixed on individual basis later.

AMDmi3 mentioned this in D7533: Introduce policy of preferring verbose logs.Aug 17 2016, 12:22 PM

Otoh, we may do an exp-run with --disable-silent-rules added to configure args (it seems to actually be supported even in very ancient configure scripts) and then probably add it to default configure args. What do you think?

Add --disable-silent-rules to CONFIGURE_ARGS to cover GNU_CONFIGURE
using ports as well. Exp-run pending.

Owners edited edge metadata.Aug 23 2016, 11:03 AM

Herald edited edge metadata. · View Herald TranscriptAug 23 2016, 11:03 AM

So trying to go unconditional --disable-silent-rules way.

This seems to work. First exp-run showed 7 failures, all easily fixed. There are 5000+ skipped ports due to these failures, another exp-run required.

Latest version of the patch:

Switch to _LATE_CONFIGURE_ARGS, only pass --disable-silent-rules when configure s known to support it
Remove --disable-silent-rules (also CMAKE/NINJA_VERBOSE) from ports which set it as this is no longer needed

Owners edited edge metadata.Sep 8 2016, 9:13 AM

Herald edited edge metadata. · View Herald TranscriptSep 8 2016, 9:13 AM

Closed by commit rP421635: Most commonly used build systems support silent builds, when they (authored by AMDmi3). · Explain WhySep 9 2016, 7:43 PM

This revision was automatically updated to reflect the committed changes.

AMDmi3 mentioned this in rP421635: Most commonly used build systems support silent builds, when they.