users: don't build when we don't have a C++ toolchain
ClosedPublic
Actions

Authored by emaste on Aug 31 2016, 8:45 PM.

Tags

None

Referenced Files

	F110539477: D7725.diff
	Wed, Feb 19, 9:13 PM

	Unknown Object (File)
	Tue, Feb 11, 1:46 PM

	Unknown Object (File)
	Wed, Feb 5, 7:09 AM

	Unknown Object (File)
	Tue, Feb 4, 8:33 PM

	Unknown Object (File)
	Thu, Jan 23, 4:36 AM

	Unknown Object (File)
	Thu, Jan 23, 4:33 AM

	Unknown Object (File)
	Jan 17 2025, 5:48 AM

	Unknown Object (File)
	Jan 9 2025, 12:06 AM

View All 61 Files

Subscribers

None

Details

Reviewers

br
bdrewery

Commits

rS305156: users: don't build when we don't have a C++ toolchain

Summary

users was disabled on RISC-V, but the issue is really just that it needs a C++ toolchain

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste updated this revision to Diff 19889.Aug 31 2016, 8:45 PM

emaste retitled this revision from to users: don't build when we don't have a C++ toolchain.

emaste updated this object.

emaste edited the test plan for this revision. (Show Details)

emaste added reviewers: br, bdrewery.

bdrewery requested changes to this revision.Aug 31 2016, 8:51 PM

bdrewery edited edge metadata.

bdrewery added inline comments.

usr.bin/Makefile
202	You lost MK_UTMPX, which src.conf(5) specifically lists users(1) in. You would need an additional .if for it.

This revision now requires changes to proceed.Aug 31 2016, 8:51 PM

restore MK_UTMPX control to users, thanks @bdrewery

bdrewery accepted this revision.Aug 31 2016, 9:07 PM

bdrewery edited edge metadata.

This revision is now accepted and ready to land.Aug 31 2016, 9:07 PM

Closed by commit rS305156: users: don't build when we don't have a C++ toolchain (authored by emaste). · Explain WhyAug 31 2016, 9:13 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

usr.bin/

Makefile

2 lines

Diff 19890

View Options

users: don't build when we don't have a C++ toolchainClosedPublicActions