Proposed XXHASH implementation.
Note that I will drop the kernel config when I commit this.
Differential D920
Proposed XXHASH implementation and change. Add support for XXHASH to pf. Leave the default as jenkins for pf and flowtable. Add an XXHASH kernel config switch. gnn on Oct 9 2014, 1:01 AM. Authored by Tags None Referenced Files
Subscribers None
Details
Diff Detail
Event Timeline
Comment Actions After all of your benchmarking is done I'd drop the knob and just make it use the new hash unconditionally.
Comment Actions I'd prefer to pull in the code and mature it over time than put it in contrib. contrib and the kernel don't mix very well for us. I have done extensive benchmarking but I'd prefer to keep this hash as optional for at least one release because I do not have a varied enough test setup to be sure of how well it will work for all cases. Also, I have not tested it in the flow case which is unrelated to pf.
Comment Actions When did this simple patch turn into an overengineered mess just begging for the kind of bug Ed just pointed out? Please take a moment to read http://bikeshed.org/, then commit D461 instead. Comment Actions Note that the proposed patch in D461 has the same potential /4 issue, it's just that it was handled there. |