Differential D61048

tftpd: Keep proper track of option length
ClosedPublic
Actions

Authored by des on Fri, Oct 30, 2:58 PM.

Project Tags

None

Referenced Files

None

Subscribers

imp

Details

Reviewers

markj

Commits

rG35cd70490f4b: tftpd: Keep proper track of option length

Summary

When parsing options, keep track of the length of the unparsed portion
and pass that to get_field() instead of the length of the entire header.

While here, switch both make_options() and parse_options() to using
size_t for sizes and lengths.

MFC after: 1 week
Event: Oslo Hackathon 2026

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

des created this revision.Fri, Oct 30, 2:58 PM

Herald added a subscriber: imp. · View Herald TranscriptFri, Oct 30, 2:58 PM

des requested review of this revision.Fri, Oct 30, 2:58 PM

Harbormaster completed remote builds in B78572: Diff 190999.Fri, Oct 30, 2:58 PM

markj accepted this revision.Wed, Nov 11, 6:10 PM

markj added inline comments.

libexec/tftpd/tftp-options.c
369	Since you're here.

This revision is now accepted and ready to land.Wed, Nov 11, 6:10 PM

des marked an inline comment as done.Wed, Nov 11, 6:20 PM

Closed by commit rG35cd70490f4b: tftpd: Keep proper track of option length. · Explain WhyWed, Nov 11, 7:46 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rG35cd70490f4b: tftpd: Keep proper track of option length.

Revision Contents
Changeset List

Path

Size

libexec/

tftpd/

tftp-options.h

6 lines

tftp-options.c

29 lines

Diff 192258

View Options

libexec/tftpd/tftp-options.h