Page MenuHomeFreeBSD
Differential D721

Add absolute/relative path logic to all custom keywords
ClosedPublic
Actions

Authored by ak on Sep 4 2014, 6:05 AM.
Tags
None
Referenced Files
F151805894: D721.id.diff
Fri, Apr 10, 7:29 PM
Unknown Object (File)
Thu, Apr 9, 4:50 AM
Unknown Object (File)
Thu, Apr 9, 2:05 AM
Unknown Object (File)
Wed, Apr 8, 10:51 AM
Unknown Object (File)
Tue, Apr 7, 12:35 PM
Unknown Object (File)
Tue, Apr 7, 6:46 AM
Unknown Object (File)
Sat, Apr 4, 7:33 AM
Unknown Object (File)
Fri, Apr 3, 3:47 AM
View All Files
Subscribers
antoine
bapt

Details

Reviewers
antoine
bapt
Group Reviewers
portmgr
Commits
rP370490: - Accept absolute path for @fc, @fontsdir, @fcfontsdir, @shell keywords
Summary

Add absolute/relative path logic to all custom keywords but fmtutils.

Test Plan

Apply the patch. Build some ports with above mentioned keywords in pkg-plist, ideally, do exp-run.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

ak updated this revision to Diff 1354.Sep 4 2014, 6:05 AM
ak retitled this revision from to Add absolute/relative path logic to all custom keywords.
ak updated this object.
ak edited the test plan for this revision. (Show Details)
ak added a reviewer: portmgr.
ak set the repository for this revision to rP FreeBSD ports repository.
antoine added a subscriber: antoine.Sep 4 2014, 6:09 AM

check-stagedir.sh has to be updated too?

antoine requested changes to this revision.Sep 4 2014, 6:15 AM
antoine added a reviewer: antoine.
This revision now requires changes to proceed.Sep 4 2014, 6:15 AM
ak updated this revision to Diff 1355.Sep 4 2014, 6:50 AM
ak edited edge metadata.

I thought it was fixed for all keywords because @sample/@rmtry were already implemented. Good catch, thanks.

antoine added a comment.Sep 24 2014, 6:06 AM

looks good

antoine accepted this revision.Sep 24 2014, 6:06 AM
antoine edited edge metadata.

looks good

This revision is now accepted and ready to land.Sep 24 2014, 6:06 AM
ak added a subscriber: bapt.Sep 26 2014, 4:31 PM

It seems that in the meantime @bapt has added a few more keywords :)
Shouldn't shared-mime-info.ucl be changed and check-stagedir.sh modified too?
Or it's a special case?

bapt accepted this revision.Oct 8 2014, 8:59 PM
bapt added a reviewer: bapt.

Please commit

ak closed this revision.Oct 8 2014, 9:39 PM
ak updated this revision to Diff 1920.

Closed by commit rP370490 (authored by @ak).

ak added a comment.Oct 8 2014, 9:42 PM

Please commit

Done.
Should I also implement it for @shared-mime-info and perhaps remove @fmutil ?

Revision Contents
Changeset List

Diff 1920

View Options

head/Keywords/fc.ucl

Loading...
View Options

head/Keywords/fcfontsdir.ucl

Loading...
View Options

head/Keywords/fontsdir.ucl

Loading...
View Options

head/Keywords/shell.ucl

Loading...
View Options

head/Mk/Scripts/check-stagedir.sh

Loading...