Page MenuHomeFreeBSD

Add absolute/relative path logic to all custom keywords
ClosedPublic

Authored by ak on Sep 4 2014, 6:05 AM.

Details

Summary

Add absolute/relative path logic to all custom keywords but fmtutils.

Test Plan

Apply the patch. Build some ports with above mentioned keywords in pkg-plist, ideally, do exp-run.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

ak retitled this revision from to Add absolute/relative path logic to all custom keywords.
ak updated this object.
ak edited the test plan for this revision. (Show Details)
ak added a reviewer: portmgr.
ak set the repository for this revision to rP FreeBSD ports repository.

check-stagedir.sh has to be updated too?

antoine requested changes to this revision.Sep 4 2014, 6:15 AM
antoine added a reviewer: antoine.
This revision now requires changes to proceed.Sep 4 2014, 6:15 AM
ak edited edge metadata.

I thought it was fixed for all keywords because @sample/@rmtry were already implemented. Good catch, thanks.

antoine edited edge metadata.

looks good

This revision is now accepted and ready to land.Sep 24 2014, 6:06 AM

It seems that in the meantime @bapt has added a few more keywords :)
Shouldn't shared-mime-info.ucl be changed and check-stagedir.sh modified too?
Or it's a special case?

bapt added a reviewer: bapt.

Please commit

ak updated this revision to Diff 1920.

Closed by commit rP370490 (authored by @ak).

Please commit

Done.
Should I also implement it for @shared-mime-info and perhaps remove @fmutil ?