libifconfig: Make unpacked variables local
AbandonedPublic
Actions

Authored by rmoeller on Wed, Nov 4, 6:00 AM.

Project Tags

None

Referenced Files

	F177559120: D61176.1794718688.diff
	Sat, Nov 14, 4:58 AM

	F177533209: D61176.1794649258.diff
	Fri, Nov 13, 9:40 AM

Subscribers

imp

Details

Reviewers

kevans

Summary

This fixes Lua 5.5 compat in the .c template, where the first loop
variable '_' becomes const in Lua 5.5, thus requiring a new binding.
The .h template is updated as well for consistency.

Reported by: Austin Horstman <khaneliman12@gmail.com>
Closes: https://github.com/freebsd/freebsd-src/pull/2473

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 78707
Build 75590: arc lint + arc unit

Event Timeline

rmoeller created this revision.Wed, Nov 4, 6:00 AM

Herald added a subscriber: imp. · View Herald TranscriptWed, Nov 4, 6:00 AM

rmoeller requested review of this revision.Wed, Nov 4, 6:00 AM

Harbormaster completed remote builds in B78707: Diff 191433.Wed, Nov 4, 6:00 AM

kevans accepted this revision.Tue, Nov 10, 2:06 PM

This revision is now accepted and ready to land.Tue, Nov 10, 2:06 PM

I didn't look at quite enough context and missed that the variables are already declared above the loop and used further down below it. I created a new diff, since git-arc didn't want to update this one.
D61455