The write-permission check on the destination file in nfsrvd_copy_file_range()
and nfsrvd_clone() tested NFSVNO_EXSTRICTACCESS() on the source export instead
of the destination export.
MFC after: 1 week
Differential D60952
nfsserver: use the destination export for the COPY/CLONE write check Authored by ojanerif_amd.com on Wed, Oct 21, 7:51 PM.
Details The write-permission check on the destination file in nfsrvd_copy_file_range() MFC after: 1 week
Diff Detail
Event TimelineComment Actions This looks right, but I note that NFSVNO_EXSTRICTACCESS is zero, so this condition is always false anyway...? Comment Actions Yes, as markj@ notes, the change is harmless The "owner override" is a hack that has existed forever Without the hack, lots of applications would break over NFS, Comment Actions Thanks both. Makes sense given the owner-override behavior. I'll keep it as a correctness fix so the check uses the destination export. |