In general it's okay, but i would like there to be a doxygen comment explaining what the call does and its expected behaviour.
(eg calling out its overflow -> clamp behaviour.)

This revision is now accepted and ready to land.Tue, Nov 3, 5:16 PM

So I approved the last one, but not this one. We need man pages for these things.

This revision now requires changes to proceed.Tue, Nov 3, 9:53 PM

In D60972#1402385, @imp wrote:

So I approved the last one, but not this one. We need man pages for these things.

There should be a .2 or a .3 file, if I understand correctly. It would be easier when OpenBSD already had a man page.

Somewhere in .9 since they are kernel only.
I'd look at tvtohz.9 as a model maybe?
I'd call the man page SEC_TO_NSEC.9 and have MLINKS for the other routines.
Shouldn't be a big add, if you need help, give a yell.

Revision Contents
Changeset List

Path

Size

sys/

time.h

8 lines

Diff 190740

View Options

introduce MSEC_TO_NSEC()Needs RevisionPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 190740

sys/sys/time.h

introduce MSEC_TO_NSEC()
Needs RevisionPublic
Actions

Revision Contents
Changeset List