The NULL return was dereferenced by the following memcpy(). Fail the
request instead.
MFC after: 1 week
Details
Details
- Reviewers
rmacklem - Commits
- rG6d705f2bf17f: rpc.tlsservd.c: Check the malloc return
Diff Detail
Diff Detail
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
Re-uploaded the diff generated with git diff -U999999 so the file paths no longer
carry the b/ prefix. No code change.
Comment Actions
This looks fine, although it is hard to imagine
how the malloc() could fail, since the process
runs as root and can only be used on 64bit systems.
If you don't have a commit bit, I'll commit it
authored by you. (Let me know if you want me
to do that?)
Comment Actions
Thanks, Rick. Agreed, it is very unlikely to fail there; the check just avoids the memcpy() into a NULL ctx if it ever does. I don't have a commit bit, so yes, please commit it with me as the author: Osvaldo Janeri Filho <ojanerif@amd.com>. Thanks!