Differential D60614

libpfctl: Fix the counts returned by pfctl_ina_define()
ClosedPublic
Actions

Authored by rcm on Oct 11 2026, 2:25 PM.

Project Tags

None

Referenced Files

None

Subscribers

imp

Details

Reviewers

Commits

rG5fc8fe3df5b9: libpfctl: Fix the counts returned by pfctl_ina_define()

Summary

The counts of a table definition were stored only if the caller's
variables already held a non-zero value, and read uninitialised ones
otherwise. pfctl_ina_define() passes the address of two uninitialised
locals and sums them up.

Fixes: 219ce3063840 ("pf: convert DIOCRINADEFINE to netlink")
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rcm created this revision.Oct 11 2026, 2:25 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 11 2026, 2:25 PM

rcm requested review of this revision.Oct 11 2026, 2:25 PM

kp accepted this revision.Oct 11 2026, 2:44 PM

This revision is now accepted and ready to land.Oct 11 2026, 2:44 PM

rcm retitled this revision from libpfctl: Test the pointers, not what they point to, in _pfctl_ina_define() to libpfctl: Fix the counts returned by pfctl_ina_define().Oct 11 2026, 2:45 PM

Closed by commit rG5fc8fe3df5b9: libpfctl: Fix the counts returned by pfctl_ina_define(). · Explain WhyOct 11 2026, 2:47 PM

This revision was automatically updated to reflect the committed changes.

rcm added a commit: rG5fc8fe3df5b9: libpfctl: Fix the counts returned by pfctl_ina_define().