Page MenuHomeFreeBSD
Differential D60080

iwm: add DQA (dynamic queue assignment)
ClosedPublic
Actions

Authored by adrian on Sun, Sep 27, 8:11 PM.
Tags
Referenced Files
F176257319: D60080.id189944.diff
Sat, Oct 17, 10:09 AM
F176181008: D60080.id187842.diff
Fri, Oct 16, 6:07 PM
F176172084: D60080.id189464.diff
Fri, Oct 16, 4:10 PM
F176170887: D60080.id188158.diff
Fri, Oct 16, 3:56 PM
Unknown Object (File)
Fri, Oct 16, 10:35 AM
Unknown Object (File)
Fri, Oct 16, 9:00 AM
Unknown Object (File)
Fri, Oct 16, 7:28 AM
Unknown Object (File)
Fri, Oct 16, 7:28 AM
View All 61 Files
Subscribers
imp
vexeduxr

Details

Reviewers
None
Group Reviewers
wireless
Commits
rG8d53176ef83d: iwm: add DQA (dynamic queue assignment)
Summary

This is the minimum set of DQA bits from iwm at the given openbsd
commit place.

  • add a method to map ac to queue / ring
  • use the DQA command queue if needed
  • glue to wire it up

Locally tested:

  • Intel 7260, STA mode
  • Intel 9260, STA mode

Obtained from: OpenBSD a6e25c727a2214219715b51ba6af2221d7e0d674

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 78004
Build 74887: arc lint + arc unit

Event Timeline

adrian created this revision.Sun, Sep 27, 8:11 PM
Herald added a subscriber: imp. · View Herald TranscriptSun, Sep 27, 8:11 PM
adrian requested review of this revision.Sun, Sep 27, 8:11 PM
Harbormaster completed remote builds in B77395: Diff 187842.Sun, Sep 27, 8:11 PM
adrian added a parent revision: D60079: iwm: add MSI-X support.Sun, Sep 27, 8:13 PM
adrian added a child revision: D60081: iwm: bring IWM_CSR_HW_IF_CONFIG_REG programming in line with openbsd.
adrian added a reviewer: wireless.Sun, Sep 27, 8:21 PM
adrian added a project: wireless.
adrian added a comment.Tue, Sep 29, 4:41 AM

a reported problem on irc:

21:27 < vexeduxr> adrian: I tested out your iwm series on a 7260, it fails on attach with "failed to send bt coex configuration: 35"

vexeduxr added a subscriber: vexeduxr.Tue, Sep 29, 3:25 PM

For some more info, the laptop is a dell latitude e7440.

hw rev 0x140, fw ver 17.352738.0

I'm just noticing that it also fails to load the firmware:

iwm7260fw: could not load firmware image, error 8

So maybe my problem is just outdated firmware?

adrian added a comment.Tue, Sep 29, 3:28 PM
In D60080#1379601, @vexeduxr wrote:

For some more info, the laptop is a dell latitude e7440.

hw rev 0x140, fw ver 17.352738.0

I'm just noticing that it also fails to load the firmware:

iwm7260fw: could not load firmware image, error 8

So maybe my problem is just outdated firmware?

nope; mine is also the same hw rev and fw ver. that check is due to the location of firmware that is being checked. it eventually picks it up.

adrian updated this revision to Diff 188158.Wed, Sep 30, 5:34 AM

oops, this actually DOES now work on the 7260/9260.
I had a whole bunch of little stupid things to fix here.

Harbormaster completed remote builds in B77514: Diff 188158.Wed, Sep 30, 5:34 AM
adrian updated this revision to Diff 188337.Thu, Oct 1, 6:43 PM

more fixes - i needed to change the sta add and sta rm to
also use the DQA queues or else I get firmware assertions!

Harbormaster completed remote builds in B77585: Diff 188337.Thu, Oct 1, 6:43 PM
adrian updated this revision to Diff 189464.Sun, Oct 11, 5:55 AM

update

Harbormaster completed remote builds in B78004: Diff 189464.Sun, Oct 11, 5:55 AM
This revision was not accepted when it landed; it landed in state Needs Review.Thu, Oct 15, 2:19 AM
Closed by commit rG8d53176ef83d: iwm: add DQA (dynamic queue assignment) (authored by adrian). · Explain Why
This revision was automatically updated to reflect the committed changes.
adrian added a commit: rG8d53176ef83d: iwm: add DQA (dynamic queue assignment).

Revision Contents
Changeset List

PathSize
sys/
dev/
iwm/
87 lines
28 lines
2 lines
1 line

Diff 189464

View Options

sys/dev/iwm/if_iwm.c

Loading...
View Options

sys/dev/iwm/if_iwm_sta.c

Loading...
View Options

sys/dev/iwm/if_iwm_util.c

Loading...
View Options

sys/dev/iwm/if_iwmvar.h

Loading...