[iwm] Fix iwm_poll_bit() usage in iwm_stop_device(), fixup r303418.
ClosedPublic
Actions

Authored by ivadasz on Jul 30 2016, 3:09 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Sep 19, 4:54 PM

	Unknown Object (File)
	Fri, Sep 11, 2:45 AM

	Unknown Object (File)
	Sat, Sep 5, 3:28 PM

	Unknown Object (File)
	Sat, Sep 5, 2:27 PM

	Unknown Object (File)
	Fri, Sep 4, 12:51 PM

	Unknown Object (File)
	Fri, Sep 4, 9:42 AM

	Unknown Object (File)
	Fri, Sep 4, 8:34 AM

	Unknown Object (File)
	Wed, Sep 2, 1:12 PM

View All Files

Subscribers

imp

Details

Reviewers

cognet
adrian

Commits

rS303557: [iwm] Fix iwm_poll_bit() usage in iwm_stop_device(), fixup r303418.

Summary

iwm_poll_bit() returns 1 on success and 0 on failure, whereas iwl_poll_bit() in Linux's iwlwifi returns >= 0 on success and < 0 on failure.

Because of the wrong iwm_poll_bit return code check, no warning was printed if tx DMA stopping failed.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4664
Build 4718: arc lint + arc unit

Event Timeline

ivadasz updated this revision to Diff 18901.Jul 30 2016, 3:09 PM

ivadasz retitled this revision from to [iwm] Fix iwm_poll_bit() usage in iwm_stop_device(), fixup r303418..

ivadasz updated this object.

ivadasz added reviewers: adrian, cognet.

Herald added a subscriber: imp. · View Herald TranscriptJul 30 2016, 3:09 PM

good!

This revision is now accepted and ready to land.Jul 30 2016, 5:02 PM

Closed by commit rS303557: [iwm] Fix iwm_poll_bit() usage in iwm_stop_device(), fixup r303418. (authored by ivadasz). · Explain WhyJul 30 2016, 7:03 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

dev/

iwm/

if_iwm.c

4 lines

Diff 18901

View Options

[iwm] Fix iwm_poll_bit() usage in iwm_stop_device(), fixup r303418.ClosedPublicActions