Page MenuHomeFreeBSD
Differential D7371

[iwm] Fix iwm_poll_bit() usage in iwm_stop_device(), fixup r303418.
ClosedPublic
Actions

Authored by ivadasz on Jul 30 2016, 3:09 PM.
Tags
None
Referenced Files
F106080065: D7371.id18905.diff
Wed, Dec 25, 1:44 AM
Unknown Object (File)
Fri, Dec 13, 8:44 AM
Unknown Object (File)
Nov 23 2024, 8:12 PM
Unknown Object (File)
Nov 11 2024, 2:49 PM
Unknown Object (File)
Nov 11 2024, 9:35 AM
Unknown Object (File)
Oct 9 2024, 4:36 AM
Unknown Object (File)
Oct 5 2024, 8:37 AM
Unknown Object (File)
Oct 4 2024, 11:58 AM
View All 78 Files
Subscribers
imp

Details

Reviewers
cognet
adrian
Commits
rS303557: [iwm] Fix iwm_poll_bit() usage in iwm_stop_device(), fixup r303418.
Summary
  • iwm_poll_bit() returns 1 on success and 0 on failure, whereas iwl_poll_bit() in Linux's iwlwifi returns >= 0 on success and < 0 on failure.
  • Because of the wrong iwm_poll_bit return code check, no warning was printed if tx DMA stopping failed.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4664
Build 4718: arc lint + arc unit

Event Timeline

ivadasz updated this revision to Diff 18901.Jul 30 2016, 3:09 PM
ivadasz retitled this revision from to [iwm] Fix iwm_poll_bit() usage in iwm_stop_device(), fixup r303418..
ivadasz updated this object.
ivadasz added reviewers: adrian, cognet.
Herald added a subscriber: imp. · View Herald TranscriptJul 30 2016, 3:09 PM
adrian accepted this revision.Jul 30 2016, 5:02 PM
adrian edited edge metadata.

good!

This revision is now accepted and ready to land.Jul 30 2016, 5:02 PM
Closed by commit rS303557: [iwm] Fix iwm_poll_bit() usage in iwm_stop_device(), fixup r303418. (authored by ivadasz). · Explain WhyJul 30 2016, 7:03 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
dev/
iwm/
4 lines

Diff 18901

View Options

sys/dev/iwm/if_iwm.c

Loading...