libthr: Do not rely on UB in counter
ClosedPublic
Actions

Authored by aokblast on Wed, Oct 7, 1:44 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Oct 8, 8:31 AM

	Unknown Object (File)
	Thu, Oct 8, 6:57 AM

	Unknown Object (File)
	Thu, Oct 8, 3:52 AM

	Unknown Object (File)
	Thu, Oct 8, 3:49 AM

	Unknown Object (File)
	Thu, Oct 8, 3:36 AM

	Unknown Object (File)
	Thu, Oct 8, 2:55 AM

	Unknown Object (File)
	Wed, Oct 7, 11:38 PM

	Unknown Object (File)
	Wed, Oct 7, 6:46 PM

Subscribers

imp

Details

Reviewers

kib

Commits

rG1d21e67e720a: libthr: Do not rely on UB in counter

Summary

counter + 1 > 0 is a undefined behavior and nobody guarantee that it
will be honestly perform by the compiler that counter + 1 will always be
INT_MIN. We switch to INT_MAX check instead to provide a deterministic
result.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 77787
Build 74670: arc lint + arc unit

Event Timeline

aokblast created this revision.Wed, Oct 7, 1:44 AM

Herald added a subscriber: imp. · View Herald TranscriptWed, Oct 7, 1:44 AM

aokblast requested review of this revision.Wed, Oct 7, 1:44 AM

Harbormaster completed remote builds in B77787: Diff 188918.Wed, Oct 7, 1:44 AM

kib accepted this revision.Wed, Oct 7, 9:12 AM

This revision is now accepted and ready to land.Wed, Oct 7, 9:12 AM

Closed by commit rG1d21e67e720a: libthr: Do not rely on UB in counter (authored by aokblast). · Explain WhyWed, Oct 7, 4:59 PM

This revision was automatically updated to reflect the committed changes.

aokblast added a commit: rG1d21e67e720a: libthr: Do not rely on UB in counter.

Revision Contents
Changeset List

Path

Size

lib/

libthr/

thread/

thr_mutex.c

4 lines

Diff 188918

View Options

lib/libthr/thread/thr_mutex.c

libthr: Do not rely on UB in counterClosedPublicActions