Paths

Table of Contentst

gen:assert_test: undefine `NDEBUG`
ClosedPublic
Actions

Authored by ngie on Fri, Oct 2, 7:32 PM.

Tags

None

Referenced Files

	F174754484: D60253.id.diff
	Mon, Oct 5, 6:43 PM

	F174725320: D60253.id188487.diff
	Mon, Oct 5, 12:47 PM

	F174721015: D60253.id188496.diff
	Mon, Oct 5, 11:48 AM

	F174706563: D60253.id.diff
	Mon, Oct 5, 9:03 AM

	F174697505: D60253.id.diff
	Mon, Oct 5, 7:21 AM

	F174683230: D60253.id188487.diff
	Mon, Oct 5, 4:16 AM

	Unknown Object (File)
	Sun, Oct 4, 8:19 PM

	Unknown Object (File)
	Sun, Oct 4, 8:10 PM

View All 22 Files

Subscribers

imp

Details

Reviewers

kevans

Commits

rG9d5a33d9c294: [tests] lib/libc/gen:assert_test: undefine `NDEBUG`

Summary

In the event NDEBUG was defined, assert would become a no-op,
breaking some of the expectations in assert_test around assert(..)
failing generating a coredump.

Suggested by: kevans
MFC after: 4 days
MFC with: 6f3445006a

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ngie created this revision.Fri, Oct 2, 7:32 PM

Herald added a subscriber: imp. · View Herald TranscriptFri, Oct 2, 7:32 PM

ngie requested review of this revision.Fri, Oct 2, 7:32 PM

Harbormaster completed remote builds in B77659: Diff 188487.Fri, Oct 2, 7:32 PM

ngie added a reviewer: kevans.Fri, Oct 2, 7:33 PM

Thanks!

This revision is now accepted and ready to land.Fri, Oct 2, 8:30 PM

Closed by commit rG9d5a33d9c294: [tests] lib/libc/gen:assert_test: undefine `NDEBUG` (authored by ngie). · Explain WhyFri, Oct 2, 8:43 PM

This revision was automatically updated to reflect the committed changes.

ngie added a commit: rG9d5a33d9c294: [tests] lib/libc/gen:assert_test: undefine `NDEBUG`.

Revision Contents
Changeset List

Path

Size

contrib/

netbsd-tests/

lib/

libc/

gen/

t_assert.c

26 lines

Diff 188496

View Options

contrib/netbsd-tests/lib/libc/gen/t_assert.c

[tests] lib/libc/gen:assert_test: undefine `NDEBUG`ClosedPublicActions