gen:assert_test: undefine `NDEBUG`
ClosedPublic
Actions

Authored by ngie on Fri, Oct 2, 7:32 PM.

Details

Reviewers

kevans

Commits

rG9d5a33d9c294: [tests] lib/libc/gen:assert_test: undefine `NDEBUG`

Summary

In the event NDEBUG was defined, assert would become a no-op,
breaking some of the expectations in assert_test around assert(..)
failing generating a coredump.

Suggested by: kevans
MFC after: 4 days
MFC with: 6f3445006a

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 77659
Build 74542: arc lint + arc unit

Event Timeline

ngie created this revision.Fri, Oct 2, 7:32 PM

Herald added a subscriber: imp. · View Herald TranscriptFri, Oct 2, 7:32 PM

ngie requested review of this revision.Fri, Oct 2, 7:32 PM

Harbormaster completed remote builds in B77659: Diff 188487.Fri, Oct 2, 7:32 PM

ngie added a reviewer: kevans.Fri, Oct 2, 7:33 PM

Thanks!

This revision is now accepted and ready to land.Fri, Oct 2, 8:30 PM

Closed by commit rG9d5a33d9c294: [tests] lib/libc/gen:assert_test: undefine `NDEBUG` (authored by ngie). · Explain WhyFri, Oct 2, 8:43 PM

This revision was automatically updated to reflect the committed changes.

ngie added a commit: rG9d5a33d9c294: [tests] lib/libc/gen:assert_test: undefine `NDEBUG`.

Revision Contents
Changeset List

Path

Size

contrib/

netbsd-tests/

lib/

libc/

gen/

t_assert.c

26 lines

Diff 188487

View Options

contrib/netbsd-tests/lib/libc/gen/t_assert.c

[tests] lib/libc/gen:assert_test: undefine `NDEBUG`ClosedPublicActions