Page MenuHomeFreeBSD
Differential D60210

tcpdrop: improve handling of -C and -S
ClosedPublic
Actions

Authored by tuexen on Thu, Oct 1, 6:36 PM.
Tags
None
Referenced Files
F174434548: D60210.diff
Sat, Oct 3, 4:48 AM
F174431436: D60210.id.diff
Sat, Oct 3, 4:05 AM
Unknown Object (File)
Fri, Oct 2, 12:51 PM
Unknown Object (File)
Fri, Oct 2, 12:27 PM
Unknown Object (File)
Fri, Oct 2, 11:43 AM
Unknown Object (File)
Fri, Oct 2, 1:16 AM
Unknown Object (File)
Fri, Oct 2, 1:16 AM
Unknown Object (File)
Fri, Oct 2, 1:07 AM
View All 11 Files
Subscribers
imp

Details

Reviewers
maxim
Commits
rGe2279d5ba9a9: tcpdrop: improve handling of -C and -S
Summary

Handle empty strings for -Cand -S correctly.

Reported by: maxim

Test Plan

tcpdrop -l -C '' and tcpdrop -l -S '' should not list any TCP connection.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tuexen created this revision.Thu, Oct 1, 6:36 PM
Herald added a subscriber: imp. · View Herald TranscriptThu, Oct 1, 6:36 PM
tuexen requested review of this revision.Thu, Oct 1, 6:36 PM
maxim accepted this revision.Thu, Oct 1, 6:48 PM

Yeah, it did the trick. Thanks.

This revision is now accepted and ready to land.Thu, Oct 1, 6:48 PM
Closed by commit rGe2279d5ba9a9: tcpdrop: improve handling of -C and -S (authored by tuexen). · Explain WhyThu, Oct 1, 7:15 PM
This revision was automatically updated to reflect the committed changes.
tuexen added a commit: rGe2279d5ba9a9: tcpdrop: improve handling of -C and -S.

Revision Contents
Changeset List

PathSize
usr.sbin/
tcpdrop/
20 lines

Diff 188339

View Options

usr.sbin/tcpdrop/tcpdrop.c

Loading...