Differential D60111

riscv/bus.h: `__bs_rs_s` takes 4 arguments, but `bus_space_read_stream_8` passes 5; please remove the extra `8` so it reads `__bs_rs_s(8,(t),(h),(o))`
ClosedPublic
Actions

Authored by shipujin.t_gmail.com on Tue, Sep 29, 2:38 AM.

Details

Reviewers

markj

Group Reviewers

riscv

Commits

rG3893050bc100: riscv: Fix the bus_space_read_stream_8 macro

Summary

Line 317:

#define bus_space_read_stream_8(t, h, o) \
    __bs_rs_s(8,8,(t),(),(o))

This macro is broken. __bs_rs_s() takes exactly four arguments:
(sz, t, h, o). The invocation above passes five arguments, so the
parameters shift.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

shipujin.t_gmail.com created this revision.Tue, Sep 29, 2:38 AM

Herald added a subscriber: imp. · View Herald TranscriptTue, Sep 29, 2:38 AM

shipujin.t_gmail.com requested review of this revision.Tue, Sep 29, 2:38 AM

shipujin.t_gmail.com retitled this revision from `__bs_rs_s` takes 4 arguments, but `bus_space_read_stream_8` passes 5; please remove the extra `8` so it reads `__bs_rs_s(8,(t),(h),(o))` to riscv/bus.h: `__bs_rs_s` takes 4 arguments, but `bus_space_read_stream_8` passes 5; please remove the extra `8` so it reads `__bs_rs_s(8,(t),(h),(o))`.Tue, Sep 29, 2:42 AM

shipujin.t_gmail.com added a reviewer: markj.

markj accepted this revision.Tue, Sep 29, 1:01 PM

This revision is now accepted and ready to land.Tue, Sep 29, 1:01 PM

Closed by commit rG3893050bc100: riscv: Fix the bus_space_read_stream_8 macro (authored by shipujin.t_gmail.com, committed by markj). · Explain WhyTue, Sep 29, 7:43 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG3893050bc100: riscv: Fix the bus_space_read_stream_8 macro.