ipmi: Add some additional diagnostic output on errors
ClosedPublic
Actions

Authored by dab on Mon, Sep 28, 11:12 AM.

Details

Reviewers

Commits

rGf3c0dcde0e20: ipmi: Add some additional diagnostic output on errors

Summary

Add some additional diagnostic output for IPMI code,
particularly on error paths. This has been found to be helpful at
$WORK and seems generally useful, so contributing the changes back to
upstream.

Test Plan

Taken from working code at $WORK
Sponsored by: Dell Technologies

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 77410
Build 74293: arc lint + arc unit

Event Timeline

dab created this revision.Mon, Sep 28, 11:12 AM

Herald added subscribers: badger, imp. · View Herald TranscriptMon, Sep 28, 11:12 AM

dab requested review of this revision.Mon, Sep 28, 11:12 AM

Harbormaster completed remote builds in B77410: Diff 187870.Mon, Sep 28, 11:12 AM

vangyzen accepted this revision.Mon, Sep 28, 11:31 AM

vangyzen added inline comments.

sys/dev/ipmi/ipmi_isa.c
255	In all four of these cases, is the error number already included in an earlier message?

This revision is now accepted and ready to land.Mon, Sep 28, 11:31 AM

dab added inline comments.Mon, Sep 28, 4:58 PM

sys/dev/ipmi/ipmi_isa.c
255	Somewhat surprisingly, no.

dab marked an inline comment as done.Mon, Sep 28, 4:58 PM

Closed by commit rGf3c0dcde0e20: ipmi: Add some additional diagnostic output on errors (authored by dab). · Explain WhyMon, Sep 28, 5:01 PM

This revision was automatically updated to reflect the committed changes.

dab added a commit: rGf3c0dcde0e20: ipmi: Add some additional diagnostic output on errors.

Revision Contents
Changeset List

Path

Size

sys/

dev/

ipmi/

ipmi_isa.c

17 lines

Diff 187870

View Options

ipmi: Add some additional diagnostic output on errorsClosedPublicActions