Obtained from: OpenBSD, 9fb1f10bfcbfc611a885a088a1658b52427addcb
Details
Details
- Reviewers
adrian - Group Reviewers
wireless - Commits
- rG6f5803e375fe: iwx: update if_iwx.c to OpenBSD v1.184 and if_iwxreg.h to OpenBSD v1.53
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 77023 Build 73906: arc lint + arc unit
Event Timeline
Comment Actions
Note - need to go double check what rinfo->rate is doing here versus rval and our rate lookup. freebsd and openbsd's rate code is a bit different.
Comment Actions
ok, from my reading, they SHOULD be the same thing for CCK and OFDM. This particular bit of code is pretty terrible though - it doesn't support HT or VHT in this path; I have no idea how static rate HT would work for management frames here (ie, the path that isn't going via firmware rate control), and VHT just isn't hooked up.
So this works under light 2GHz/5GHz testing, but once the iwx driver is updated to the latest code in openbsd I think it's worth us implementing a freebsd specific version of this and adding in all the HT/VHT rates in the iwx rates array.
Comment Actions
right; we shouldn't need to update rval from the rate table again, as it's already been looked up earlier.