Differential D59674

amdsmu: Hints on what to do if IP block blocking S0i3
ClosedPublic
Actions

Authored by obiwac on Mon, Sep 14, 6:56 PM.

Tags

None

Referenced Files

	F172355656: D59674.diff
	Thu, Sep 17, 10:24 PM

	F172336498: D59674.id186928.diff
	Thu, Sep 17, 7:53 PM

	Unknown Object (File)
	Thu, Sep 17, 8:02 AM

	Unknown Object (File)
	Thu, Sep 17, 5:46 AM

	Unknown Object (File)
	Thu, Sep 17, 1:22 AM

	Unknown Object (File)
	Thu, Sep 17, 12:53 AM

	Unknown Object (File)
	Wed, Sep 16, 8:41 AM

	Unknown Object (File)
	Tue, Sep 15, 2:33 PM

View All 13 Files

Subscribers

Details

Reviewers

Commits

rG758578370f6b: amdsmu: Hints on what to do if IP block blocking S0i3

Summary

Sponsored by: The FreeBSD Foundation

Test Plan

Same as D59673

This is what the output looks like if I don't load thunderbolt(4):

amdsmu0: failed to enter S0i3 during last suspend; battery drain will be excessive
amdsmu0: IP blocks that blocked S0i3 entry:
amdsmu0:   CPU (active for 3865335 us)
amdsmu0:     hint: this can happen due to other IP blocks
amdsmu0:   USB3_0 (active for 3865335 us)
amdsmu0:     hint: load tb to allow this block to suspend
amdsmu0:     hint: see thunderbolt(4)
amdsmu0:   USB3_1 (active for 3865335 us)
amdsmu0:     hint: load tb to allow this block to suspend
amdsmu0:     hint: see thunderbolt(4)
amdsmu0:   MPM (active for 3865335 us)
amdsmu0:     hint: this can happen due to other IP blocks

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 76895
Build 73778: arc lint + arc unit

Event Timeline

obiwac created this revision.Mon, Sep 14, 6:56 PM

Herald added a subscriber: imp. · View Herald TranscriptMon, Sep 14, 6:56 PM

obiwac requested review of this revision.Mon, Sep 14, 6:56 PM

Harbormaster completed remote builds in B76895: Diff 186709.Mon, Sep 14, 6:56 PM

obiwac added a parent revision: D59673: amdsmu: Diagnose S0i3 entry after resume.Mon, Sep 14, 6:57 PM

obiwac edited the test plan for this revision. (Show Details)Wed, Sep 16, 6:37 PM

better hints & truly ignore IP blocks meant to be ignored

Harbormaster completed remote builds in B76997: Diff 186910.Wed, Sep 16, 6:54 PM

more help for CPU and MPM IP blocks

Harbormaster completed remote builds in B77007: Diff 186928.Thu, Sep 17, 12:20 AM

olce accepted this revision.Fri, Sep 18, 7:35 AM

olce added inline comments.

sys/dev/amdsmu/amdsmu.c
355–359	Inverting the test makes for more compact code, but that's fine.

This revision is now accepted and ready to land.Fri, Sep 18, 7:35 AM

olce added a child revision: D59788: amdsmu: Fix model-specific matching.Fri, Sep 18, 7:52 AM

Closed by commit rG758578370f6b: amdsmu: Hints on what to do if IP block blocking S0i3 (authored by obiwac). · Explain WhyFri, Sep 18, 11:00 AM

This revision was automatically updated to reflect the committed changes.

obiwac added a commit: rG758578370f6b: amdsmu: Hints on what to do if IP block blocking S0i3.

Revision Contents
Changeset List

Path

Size

sys/

dev/

amdsmu/

17 lines

16 lines

Diff 186709

sys/dev/amdsmu/amdsmu.h

Loading...

sys/dev/amdsmu/amdsmu.c

Loading...