Differential D59608
LinuxKPI: 802.11: Always lock around lkpi_{ic_vap_delete,mo_stop}() Authored by temcbun_gmail.com on Sat, Sep 12, 9:16 AM. Tags Referenced Files
Details Add the missing locking as drivers always expect it (by assertion) and cannot distinguish between state. Add the assertions to the downcalls as we need both of them locked and both of them can sleep. PR: 298417 I tried to implement the changes to fix the bug, introduced in the PR, based on 5d479b75a894, which fixed the similar problem. With this patch applied and the INVARIANTS kernel, destroying the rtw89(4) interface should not freeze the system: $ ifconfig wlan create wlandev rtw890 wlan0 $ ifconfig wlan0 destroy
Diff Detail
Event TimelineComment Actions I'll commit this with my next batch. Thanks for this! I thought (twice now) that I pushed updates for all of them but it seems I last time also only pushed the one to fix the PR. I have a further issue in that I currently cannot even load rtw89 after a rebase of main; I am not sure what changed to cause that yet :( *sigh* Comment Actions It's on the list with 16 others for, likely, Sunday evening. I am trying to batch the MFCs. |