Page MenuHomeFreeBSD
Differential D59346

contrib/kyua: fix -Wshadow error
ClosedPublic
Actions

Authored by siva on Thu, Sep 3, 3:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Sep 6, 6:09 AM
Unknown Object (File)
Sun, Sep 6, 2:22 AM
Unknown Object (File)
Sat, Sep 5, 7:31 PM
Unknown Object (File)
Sat, Sep 5, 4:55 PM
Unknown Object (File)
Sat, Sep 5, 2:12 AM
Unknown Object (File)
Fri, Sep 4, 12:05 PM
Unknown Object (File)
Fri, Sep 4, 5:56 AM
Unknown Object (File)
Fri, Sep 4, 2:06 AM
View All 14 Files
Subscribers
imp

Details

Reviewers
igoro
ngie
rlibby
Commits
rGa73bb621ca36: contrib/kyua: fix -Wshadow error
Summary

This fixes the build with gcc 14:

contrib/kyua/engine/prepare/prepare_all.cpp:56:16: error: declaration of 'handler' shadows a member of 'engine::prepare::prepare_all' [-Werror=shadow]

56 |     for (auto& handler : prepare::handlers()) {
   |                ^~~~~~~

In file included from /home/siva/f/main/contrib/kyua/engine/prepare/prepare_all.hpp:35,

from /home/siva/f/main/contrib/kyua/engine/prepare/prepare_all.cpp:29:

/home/siva/f/main/contrib/kyua/engine/prepare/prepare.hpp:51:15: note: shadowed declaration is here

51 | class handler {
   |               ^

Fixes: edb230c4af499203d7a6894b3711fe6574b26040

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 76430
Build 73313: arc lint + arc unit

Event Timeline

siva created this revision.Thu, Sep 3, 3:23 PM
Herald added a subscriber: imp. · View Herald TranscriptThu, Sep 3, 3:23 PM
siva requested review of this revision.Thu, Sep 3, 3:23 PM
Harbormaster completed remote builds in B76430: Diff 185712.Thu, Sep 3, 3:23 PM
ngie accepted this revision.Thu, Sep 3, 4:26 PM

@igoro when the time comes, could you please submit this upstream as well along with the prepare support?

This revision is now accepted and ready to land.Thu, Sep 3, 4:26 PM
igoro accepted this revision.Thu, Sep 3, 4:48 PM

LGTM. The funny thing is that originally it was h.

igoro added a comment.Thu, Sep 3, 4:49 PM
In D59346#1361743, @ngie wrote:

@igoro when the time comes, could you please submit this upstream as well along with the prepare support?

Yes, this is what I was thinking about, considering you're working towards the next release.

ngie mentioned this in D59354: kyua: un-shadow handle variable to fix gcc build.Fri, Sep 4, 5:33 AM
rlibby accepted this revision.Fri, Sep 4, 5:41 AM
Closed by commit rGa73bb621ca36: contrib/kyua: fix -Wshadow error (authored by siva). · Explain WhySat, Sep 5, 2:13 PM
This revision was automatically updated to reflect the committed changes.
siva added a commit: rGa73bb621ca36: contrib/kyua: fix -Wshadow error.

Revision Contents
Changeset List

PathSize
contrib/
kyua/
engine/
prepare/
6 lines

Diff 185712

View Options

contrib/kyua/engine/prepare/prepare_all.cpp

Loading...