Page MenuHomeFreeBSD
Differential D59274

Assign and test `malloc` result separately
ClosedPublic
Actions

Authored by ngie on Sun, Aug 30, 6:34 PM.
Tags
None
Referenced Files
F170994897: D59274.id185445.diff
Tue, Sep 8, 2:03 AM
F170965559: D59274.id186020.diff
Mon, Sep 7, 9:57 PM
Unknown Object (File)
Sun, Sep 6, 3:12 PM
Unknown Object (File)
Sun, Sep 6, 6:44 AM
Unknown Object (File)
Sat, Sep 5, 11:35 PM
Unknown Object (File)
Sat, Sep 5, 1:49 PM
Unknown Object (File)
Fri, Sep 4, 11:45 PM
Unknown Object (File)
Fri, Sep 4, 7:35 PM
View All 21 Files
Subscribers
imp
Src Committers

Details

Reviewers
des
Commits
rG2561c468c113: Assign and test `malloc` result separately
Summary

The previous pattern is cited as an issue with ATF 0.22+ when using
clang/gcc post-[1].

MFC after: 2 weeks
Reported by: clang (-Wparenthesis)

[1]: https://github.com/freebsd/atf/pull/72

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 76334
Build 73217: arc lint + arc unit

Event Timeline

ngie created this revision.Sun, Aug 30, 6:34 PM
Herald added a subscriber: imp. · View Herald TranscriptSun, Aug 30, 6:34 PM
ngie requested review of this revision.Sun, Aug 30, 6:34 PM
Harbormaster completed remote builds in B76334: Diff 185445.Sun, Aug 30, 6:34 PM
ngie added a reviewer: des.Sun, Aug 30, 6:35 PM
ngie added a subscriber: Src Committers.
This revision was not accepted when it landed; it landed in state Needs Review.Sun, Sep 6, 7:19 PM
Closed by commit rG2561c468c113: Assign and test `malloc` result separately (authored by ngie). · Explain Why
This revision was automatically updated to reflect the committed changes.
ngie added a commit: rG2561c468c113: Assign and test `malloc` result separately.

Revision Contents
Changeset List

PathSize
lib/
libc/
tests/
stdlib/
2 lines

Diff 185445

View Options

lib/libc/tests/stdlib/qsort_bench.c

Loading...