uchcom: Set rate to 1
AcceptedPublic
Actions

Authored by aokblast on Sat, Aug 22, 8:43 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Sep 8, 3:19 AM

	Unknown Object (File)
	Tue, Sep 8, 2:28 AM

	Unknown Object (File)
	Sat, Sep 5, 12:37 PM

	Unknown Object (File)
	Sat, Sep 5, 9:53 AM

	Unknown Object (File)
	Fri, Sep 4, 4:32 PM

	Unknown Object (File)
	Fri, Sep 4, 6:12 AM

	Unknown Object (File)
	Fri, Sep 4, 4:58 AM

	Unknown Object (File)
	Thu, Sep 3, 2:24 PM

View All 39 Files

Subscribers

imp

Details

Reviewers

imp
emaste

Group Reviewers

USB

Summary

If userspace provides rate == 0, it causes kernel panic as rate is
directly used as a divident, which cannot be zero. Fix it by set the
rate to 1 if it is zero.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 75967
Build 72850: arc lint + arc unit

Event Timeline

aokblast created this revision.Sat, Aug 22, 8:43 PM

Herald added a subscriber: imp. · View Herald TranscriptSat, Aug 22, 8:43 PM

aokblast requested review of this revision.Sat, Aug 22, 8:43 PM

Harbormaster completed remote builds in B75967: Diff 184742.Sat, Aug 22, 8:43 PM

aokblast added a reviewer: USB.Sat, Aug 22, 8:44 PM

imp accepted this revision.Sun, Aug 23, 12:40 AM

This revision is now accepted and ready to land.Sun, Aug 23, 12:40 AM

emaste accepted this revision.Sun, Aug 23, 6:15 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

usb/

serial/

uchcom.c

3 lines

Diff 184742

View Options

sys/dev/usb/serial/uchcom.c

uchcom: Set rate to 1AcceptedPublicActions