net/rsync: Update to 3.5.0
Needs ReviewPublic
Actions

Authored by rodrigo on Thu, Aug 13, 7:52 AM.

Details

Reviewers

des
zi

Summary

Changelog: https://download.samba.org/pub/rsync/NEWS#3.5.0

Security: CVE-2026-29518
Security: CVE-2026-43617
Security: CVE-2026-43618
Security: CVE-2026-43619
Security: CVE-2026-43620
Security: CVE-2026-45232

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 75958
Build 72841: arc lint + arc unit

Event Timeline

rodrigo requested review of this revision.Thu, Aug 13, 7:52 AM

rodrigo created this revision.

Harbormaster completed remote builds in B75550: Diff 183967.Thu, Aug 13, 7:52 AM

The rsync project has released a security release this month, featuring major internal changes to address multiple CVE issues.

As expected, this update breaks the file flag patch ported to version 3.4.4.
I have successfully ported most of the code to the new version and having some doubts,
I use Claude LLM to review my changes and to add regression tests for the file flags feature.

The synthesis of the changes made by the LLM are available here: https://people.freebsd.org/~rodrigo/rsync_ff_changes_claude_report.md

Currently, the rsync v3.5.0 port builds successfully and passes the existing rsync non-regression tests, including the new file-flag test.

Can you please submit the patch upstream?

net/rsync/Makefile
98	You should use `shebangfix` instead.

rodrigo added inline comments.Wed, Aug 19, 8:41 AM

net/rsync/Makefile
98	This line does not only fix the shebang, it cover a few other cases Not sure shebangfix usage made here things simpler for the remaining exceptions. testsuite/fleettest.py has multiple directs calls to python3 testsuite/<another_script>.py testsuite/rrsync-symlink_test.py and testsuite/daemon-namecvt-newline-token_test.py generate a python script wit its own shebang fake_rsync.write_text( "#!/usr/bin/env python3\n" "import sys\n" "try:\n" testsuite/file-flags_test.py use env, which is not corrected by the sebangfix #!/usr/bin/env python3

rodrigo added a reviewer: zi.Fri, Aug 21, 7:14 PM

Revert changes done by claude to the manpage source to match the original version.
And since 780d5edd16d3542e9946905cec8d8028772e5724 the manpage is not generated
during the build anymore, create a patch to fix the pre-generated one.

Harbormaster completed remote builds in B75958: Diff 184701.Fri, Aug 21, 9:44 PM

Hi,

If there is no additional remarks on this review,
and having all rsync internal test and my own
manual ones passed with success, I plan to
commit it on Friday.

Please don't view this as an attempt to force the review,
but at some point, rsync will have to be updated.

Regards

In D58814#1356519, @rodrigo wrote:

If there is no additional remarks on this review,
and having all rsync internal test and my own
manual ones passed with success, I plan to
commit it on Friday.

Please don't view this as an attempt to force the review,
but at some point, rsync will have to be updated.

You're the maintainer, you don't need anyone's permission.