Page MenuHomeFreeBSD

net/rsync: Update to 3.5.0
Needs ReviewPublic

Authored by rodrigo on Thu, Aug 13, 7:52 AM.
Tags
None
Referenced Files
F167170409: D58814.diff
Wed, Aug 19, 3:46 PM
Unknown Object (File)
Sat, Aug 15, 5:31 PM
Unknown Object (File)
Fri, Aug 14, 7:39 PM
Unknown Object (File)
Thu, Aug 13, 9:03 PM
Unknown Object (File)
Thu, Aug 13, 12:31 PM
Subscribers
None

Details

Reviewers
des
Summary

Changelog: https://download.samba.org/pub/rsync/NEWS#3.5.0

Security: CVE-2026-29518
Security: CVE-2026-43617
Security: CVE-2026-43618
Security: CVE-2026-43619
Security: CVE-2026-43620
Security: CVE-2026-45232

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 75550
Build 72433: arc lint + arc unit

Event Timeline

rodrigo created this revision.

The rsync project has released a security release this month, featuring major internal changes to address multiple CVE issues.

As expected, this update breaks the file flag patch ported to version 3.4.4.
I have successfully ported most of the code to the new version and having some doubts,
I use Claude LLM to review my changes and to add regression tests for the file flags feature.

The synthesis of the changes made by the LLM are available here: https://people.freebsd.org/~rodrigo/rsync_ff_changes_claude_report.md

Currently, the rsync v3.5.0 port builds successfully and passes the existing rsync non-regression tests, including the new file-flag test.

Can you please submit the patch upstream?

net/rsync/Makefile
98

You should use shebangfix instead.

net/rsync/Makefile
98

This line does not only fix the shebang, it cover a few other cases
Not sure shebangfix usage made here things simpler for the remaining exceptions.

testsuite/fleettest.py has multiple directs calls to

python3 testsuite/<another_script>.py

testsuite/rrsync-symlink_test.py and testsuite/daemon-namecvt-newline-token_test.py generate a python script wit its own shebang

fake_rsync.write_text(
    "#!/usr/bin/env python3\n"
    "import sys\n"
    "try:\n"

testsuite/file-flags_test.py use env, which is not corrected by the sebangfix

#!/usr/bin/env python3