Page MenuHomeFreeBSD
Differential D58896

netmap: Use ckdint.h helpers to check for overflow
ClosedPublic
Actions

Authored by markj on Aug 17 2026, 6:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Sep 22, 12:20 AM
Unknown Object (File)
Tue, Sep 22, 12:19 AM
Unknown Object (File)
Sun, Sep 20, 7:37 PM
Unknown Object (File)
Thu, Sep 17, 9:53 AM
Unknown Object (File)
Tue, Sep 15, 11:14 PM
Unknown Object (File)
Mon, Sep 14, 5:25 AM
Unknown Object (File)
Sun, Sep 13, 7:51 AM
Unknown Object (File)
Fri, Sep 11, 8:29 PM
View All 69 Files
Subscribers
imp

Details

Reviewers
vmaffione
Commits
rGd6f5c6531e48: netmap: Use ckdint.h helpers to check for overflow
Summary

This addresses a bug in the addition overflow check added in commit
319414a926af ("netmap: Handle overflow when computing ring sizes"): that
overflow wasn't actually caught by the check because "len" is promoted
to size_t.

Fixes: 319414a926af ("netmap: Handle overflow when computing ring sizes")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 75656
Build 72539: arc lint + arc unit

Event Timeline

markj created this revision.Aug 17 2026, 6:43 PM
Herald added a subscriber: imp. · View Herald TranscriptAug 17 2026, 6:43 PM
markj requested review of this revision.Aug 17 2026, 6:43 PM
Harbormaster completed remote builds in B75656: Diff 184212.Aug 17 2026, 6:43 PM
This revision was not accepted when it landed; it landed in state Needs Review.Thu, Aug 27, 1:33 PM
Closed by commit rGd6f5c6531e48: netmap: Use ckdint.h helpers to check for overflow (authored by markj). · Explain Why
This revision was automatically updated to reflect the committed changes.
markj added a commit: rGd6f5c6531e48: netmap: Use ckdint.h helpers to check for overflow.

Revision Contents
Changeset List

PathSize
sys/
dev/
netmap/
10 lines

Diff 184212

View Options

sys/dev/netmap/netmap_mem2.c

Loading...