Page MenuHomeFreeBSD

bce_vhci: fix duplicate endpoint queue registration, ratelimit failure logging
AcceptedPublic

Authored by guest-seuros on Thu, Aug 13, 6:49 PM.
Tags
None
Referenced Files
F167648824: D58831.id184014.diff
Sun, Aug 23, 12:26 PM
Unknown Object (File)
Sat, Aug 22, 8:20 PM
Unknown Object (File)
Sat, Aug 22, 11:06 AM
Unknown Object (File)
Sat, Aug 22, 3:11 AM
Unknown Object (File)
Thu, Aug 20, 11:01 PM
Unknown Object (File)
Thu, Aug 20, 12:06 AM
Unknown Object (File)
Wed, Aug 19, 9:44 AM
Unknown Object (File)
Mon, Aug 17, 9:15 PM
Subscribers

Details

Reviewers
adrian
Summary

bce_vhci_endpoint_create() was registering both the IN and OUT
submission queues on every call, regardless of which direction
the endpoint actually needed.
The per-stage firmware registration failures weren't rate-limited,
so a stuck registration will spam the console.

Tested on:
MacBookPro15,2
Macmini8,1
MacBookPro15,3
MacBookPro16,2

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 75573
Build 72456: arc lint + arc unit

Event Timeline

looks fine; just add a Tested: section on which macs you've tested it on and then i'll mrge it.

This revision is now accepted and ready to land.Thu, Aug 13, 8:32 PM