Page MenuHomeFreeBSD
Differential D58819

ufshci: correct the crypto/config register offsets and HCMID fields
ClosedPublic
Actions

Authored by jaeyoon on Thu, Aug 13, 8:42 AM.
Tags
None
Referenced Files
F167316595: D58819.id184233.diff
Thu, Aug 20, 8:57 PM
F167315154: D58819.diff
Thu, Aug 20, 8:49 PM
F167291379: D58819.id184227.diff
Thu, Aug 20, 5:14 PM
F167266702: D58819.id184233.diff
Thu, Aug 20, 12:52 PM
Unknown Object (File)
Wed, Aug 19, 5:06 PM
Unknown Object (File)
Wed, Aug 19, 4:18 PM
Unknown Object (File)
Tue, Aug 18, 6:31 AM
Unknown Object (File)
Thu, Aug 13, 12:15 PM
Subscribers
None

Details

Reviewers
imp
Commits
rG34518292a3e0: ufshci: correct the crypto/config register offsets and HCMID fields
Summary

The reserved array after CCAP must be 127 dwords, but it was 511.
This pushed the config, MCQ config, and ESI registers from 0x300 and
0x380 up to 0x900. None of these registers are used yet, so nothing
broke.

Also fix the HCMID bank index field. The spec places it at bits
[23:16], but it was defined on top of the manufacturer code at [15:0].

Sponsored by: Samsung Electronics

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 75555
Build 72438: arc lint + arc unit

Event Timeline

jaeyoon requested review of this revision.Thu, Aug 13, 8:42 AM
jaeyoon created this revision.
Harbormaster completed remote builds in B75555: Diff 183972.Thu, Aug 13, 8:42 AM
jaeyoon added a parent revision: D58818: ufshci: consolidate the device query submit/poll pattern.Thu, Aug 13, 8:43 AM
jaeyoon added a child revision: D58820: ufshci: report the highest LUN number in the path inquiry.
imp accepted this revision.Fri, Aug 14, 9:09 PM

The change looks good, just wondering about the inconsistency.

sys/dev/ufshci/ufshci_reg.h
64

why the error? I think the new one is right, but there's got to be a better way to get the stride right. There's also a mix of uint32_t and uint8_t. Is there a reason for that?

This revision is now accepted and ready to land.Fri, Aug 14, 9:09 PM
jaeyoon updated this revision to Diff 184227.Tue, Aug 18, 4:40 AM

set it to uint8_t and added a static_assert.

This revision now requires review to proceed.Tue, Aug 18, 4:40 AM
Harbormaster completed remote builds in B75663: Diff 184227.Tue, Aug 18, 4:40 AM
jaeyoon added a comment.Tue, Aug 18, 4:42 AM

Since this isn't a major change, I'll go ahead and push it as is.

This revision was not accepted when it landed; it landed in state Needs Review.Tue, Aug 18, 5:26 AM
Closed by commit rG34518292a3e0: ufshci: correct the crypto/config register offsets and HCMID fields (authored by jaeyoon). · Explain Why
This revision was automatically updated to reflect the committed changes.
jaeyoon added a commit: rG34518292a3e0: ufshci: correct the crypto/config register offsets and HCMID fields.

Revision Contents
Changeset List

PathSize
sys/
dev/
ufshci/
6 lines

Diff 183972

View Options

sys/dev/ufshci/ufshci_reg.h

Loading...