ufshci: correct the crypto/config register offsets and HCMID fields
AcceptedPublic
Actions

Authored by jaeyoon on Thu, Aug 13, 8:42 AM.

Details

Reviewers

Summary

The reserved array after CCAP must be 127 dwords, but it was 511.
This pushed the config, MCQ config, and ESI registers from 0x300 and
0x380 up to 0x900. None of these registers are used yet, so nothing
broke.

Also fix the HCMID bank index field. The spec places it at bits
[23:16], but it was defined on top of the manufacturer code at [15:0].

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 75555
Build 72438: arc lint + arc unit

Event Timeline

jaeyoon requested review of this revision.Thu, Aug 13, 8:42 AM

jaeyoon created this revision.

Harbormaster completed remote builds in B75555: Diff 183972.Thu, Aug 13, 8:42 AM

jaeyoon added a parent revision: D58818: ufshci: consolidate the device query submit/poll pattern.Thu, Aug 13, 8:43 AM

jaeyoon added a child revision: D58820: ufshci: report the highest LUN number in the path inquiry.

The change looks good, just wondering about the inconsistency.

sys/dev/ufshci/ufshci_reg.h
64	why the error? I think the new one is right, but there's got to be a better way to get the stride right. There's also a mix of uint32_t and uint8_t. Is there a reason for that?

This revision is now accepted and ready to land.Fri, Aug 14, 9:09 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

ufshci/

ufshci_reg.h

6 lines

Diff 183972

View Options

sys/dev/ufshci/ufshci_reg.h

ufshci: correct the crypto/config register offsets and HCMID fieldsAcceptedPublicActions