ufshci: consolidate the device query submit/poll pattern
ClosedPublic
Actions

Authored by jaeyoon on Thu, Aug 13, 8:41 AM.

Details

Reviewers

Commits

rGe1aa173f8120: ufshci: consolidate the device query submit/poll pattern

Summary

The six query helpers duplicated the same submit, error check, poll,
and status check sequence. Move it into ufshci_dev_send_query() so
future changes to the query flow are made in one place. This also
unifies the failure log message format.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 75554
Build 72437: arc lint + arc unit

Event Timeline

jaeyoon requested review of this revision.Thu, Aug 13, 8:41 AM

jaeyoon created this revision.

Harbormaster completed remote builds in B75554: Diff 183971.Thu, Aug 13, 8:41 AM

jaeyoon added a parent revision: D58817: ufshci: validate the CDB before allocating a request.Thu, Aug 13, 8:41 AM

jaeyoon added a child revision: D58819: ufshci: correct the crypto/config register offsets and HCMID fields.

imp accepted this revision.Fri, Aug 14, 9:06 PM

This revision is now accepted and ready to land.Fri, Aug 14, 9:06 PM

Closed by commit rGe1aa173f8120: ufshci: consolidate the device query submit/poll pattern (authored by jaeyoon). · Explain WhyTue, Aug 18, 5:26 AM

This revision was automatically updated to reflect the committed changes.

jaeyoon added a commit: rGe1aa173f8120: ufshci: consolidate the device query submit/poll pattern.

Revision Contents
Changeset List

Path

Size

sys/

dev/

ufshci/

ufshci_dev.c

98 lines

Diff 183971

View Options

sys/dev/ufshci/ufshci_dev.c

ufshci: consolidate the device query submit/poll patternClosedPublicActions