ufshci: validate the CDB before allocating a request
ClosedPublic
Actions

Authored by jaeyoon on Thu, Aug 13, 8:39 AM.

Tags

None

Referenced Files

	F167222942: D58817.diff
	Thu, Aug 20, 2:08 AM

	F167181114: D58817.id183970.diff
	Wed, Aug 19, 5:04 PM

	F167176069: D58817.id183970.diff
	Wed, Aug 19, 4:27 PM

	Unknown Object (File)
	Tue, Aug 18, 11:29 PM

	Unknown Object (File)
	Tue, Aug 18, 10:03 PM

	Unknown Object (File)
	Tue, Aug 18, 8:13 PM

	Unknown Object (File)
	Tue, Aug 18, 1:29 PM

	Unknown Object (File)
	Tue, Aug 18, 7:01 AM

View All 11 Files

Subscribers

None

Details

Reviewers

imp

Commits

rGf3c3db35d545: ufshci: validate the CDB before allocating a request

Summary

The CDB pointer and length checks depend only on the CCB, so perform
them before allocating and initializing the request. This avoids a
wasted allocation for invalid CCBs on the I/O path and removes one
request-free error path.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 75553
Build 72436: arc lint + arc unit

Event Timeline

jaeyoon requested review of this revision.Thu, Aug 13, 8:39 AM

jaeyoon created this revision.

Harbormaster completed remote builds in B75553: Diff 183970.Thu, Aug 13, 8:39 AM

jaeyoon added a parent revision: D58816: ufshci: pass the queue being destroyed to the cmd descriptor teardown.Thu, Aug 13, 8:40 AM

jaeyoon added a child revision: D58818: ufshci: consolidate the device query submit/poll pattern.

imp accepted this revision.Fri, Aug 14, 9:06 PM

This revision is now accepted and ready to land.Fri, Aug 14, 9:06 PM

Closed by commit rGf3c3db35d545: ufshci: validate the CDB before allocating a request (authored by jaeyoon). · Explain WhyTue, Aug 18, 5:26 AM

This revision was automatically updated to reflect the committed changes.

jaeyoon added a commit: rGf3c3db35d545: ufshci: validate the CDB before allocating a request.

Revision Contents
Changeset List

Path

Size

sys/

dev/

ufshci/

ufshci_sim.c

22 lines

Diff 183970

View Options

sys/dev/ufshci/ufshci_sim.c

ufshci: validate the CDB before allocating a requestClosedPublicActions