ufshci: pass the queue being destroyed to the cmd descriptor teardown
ClosedPublic
Actions

Authored by jaeyoon on Thu, Aug 13, 8:38 AM.

Details

Reviewers

Commits

rGdbcebc7c661e: ufshci: pass the queue being destroyed to the cmd descriptor teardown

Summary

ufshci_req_sdb_destroy() hardcoded &ctrlr->transfer_req_queue when
destroying command descriptors instead of using its req_queue argument.

No functional change: the branch only runs for the transfer queue, so
the two pointers are always the same today. Using the argument keeps
the function queue-agnostic for when more transfer queues exist (MCQ).

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 75552
Build 72435: arc lint + arc unit

Event Timeline

jaeyoon requested review of this revision.Thu, Aug 13, 8:38 AM

jaeyoon created this revision.

Harbormaster completed remote builds in B75552: Diff 183969.Thu, Aug 13, 8:38 AM

jaeyoon added a parent revision: D58815: ufshci: return the real errno from SDB queue construction.Thu, Aug 13, 8:38 AM

jaeyoon added a child revision: D58817: ufshci: validate the CDB before allocating a request.

imp accepted this revision.Fri, Aug 14, 9:05 PM

This revision is now accepted and ready to land.Fri, Aug 14, 9:05 PM

Closed by commit rGdbcebc7c661e: ufshci: pass the queue being destroyed to the cmd descriptor teardown (authored by jaeyoon). · Explain WhyTue, Aug 18, 5:26 AM

This revision was automatically updated to reflect the committed changes.

jaeyoon added a commit: rGdbcebc7c661e: ufshci: pass the queue being destroyed to the cmd descriptor teardown.

Revision Contents
Changeset List

Path

Size

sys/

dev/

ufshci/

ufshci_req_sdb.c

3 lines

Diff 183969

View Options

sys/dev/ufshci/ufshci_req_sdb.c

ufshci: pass the queue being destroyed to the cmd descriptor teardownClosedPublicActions