Differential D58507

Add new src committer: Minsoo Choo (mchoo)
ClosedPublic
Actions

Authored by mchoo on Tue, Jul 28, 3:05 AM.

Tags

None

Referenced Files

	F164730915: D58507.id183088.diff
	Mon, Aug 3, 10:00 AM

	F164654098: D58507.id183136.diff
	Sun, Aug 2, 11:40 PM

	F164652035: D58507.id183088.diff
	Sun, Aug 2, 11:01 PM

	F164637298: D58507.id182889.diff
	Sun, Aug 2, 6:43 PM

	Unknown Object (File)
	Sun, Aug 2, 12:15 PM

	Unknown Object (File)
	Sun, Aug 2, 11:41 AM

	Unknown Object (File)
	Sun, Aug 2, 6:16 AM

	Unknown Object (File)
	Sun, Aug 2, 4:37 AM

View All 18 Files

Subscribers

Details

Reviewers

Commits

rGa28c2890f448: Add new src committer: Minsoo Choo (mchoo)

Summary

Completed steps 5-6 and 10 in the committer's guide.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 75205
Build 72088: arc lint + arc unit

Event Timeline

mchoo created this revision.Tue, Jul 28, 3:05 AM

Herald added a subscriber: imp. · View Herald TranscriptTue, Jul 28, 3:05 AM

mchoo requested review of this revision.Tue, Jul 28, 3:05 AM

Harbormaster completed remote builds in B75205: Diff 182889.Tue, Jul 28, 3:05 AM

mchoo mentioned this in D58508: Add new src committer: Minsoo Choo (mchoo).Tue, Jul 28, 3:12 AM

Oh, hmm, I must have been dropped from the cc when your account was setup as I was still waiting for that to happen, but it seems your account is all setup now. I need to go add you to access first and then you can start landing these.

This revision is now accepted and ready to land.Wed, Jul 29, 7:04 PM

Update date
Add mentor-mentee entry

I don't know if I should follow the alphabetical order or append to the tail for the mentor-mentee list. Mentees under a same mentor seems to be sorted alphabetically, but there are a few exceptions.

This revision now requires review to proceed.Thu, Jul 30, 2:48 AM

Harbormaster completed remote builds in B75286: Diff 183088.Thu, Jul 30, 2:48 AM

jhb accepted this revision.Thu, Jul 30, 12:32 PM

jhb added inline comments.

share/misc/committers-src.dot
680	I think this is correct here

This revision is now accepted and ready to land.Thu, Jul 30, 12:32 PM

Closed by commit rGa28c2890f448: Add new src committer: Minsoo Choo (mchoo) (authored by mchoo). · Explain WhyThu, Jul 30, 9:08 PM

This revision was automatically updated to reflect the committed changes.

mchoo added a commit: rGa28c2890f448: Add new src committer: Minsoo Choo (mchoo).

Revision Contents
Changeset List

Path

Size

2 lines

share/

misc/

committers-src.dot

1 line

usr.bin/

calendar/

calendars/

calendar.freebsd

1 line

Diff 182889

.mailmap

Loading...

share/misc/committers-src.dot

Loading...

usr.bin/calendar/calendars/calendar.freebsd

Loading...