bhnd(4): Implement generic support for discovery of platform devices (PMU, NVRAM, ChipCommon, etc).
ClosedPublic
Actions

Authored by landonf on Jun 25 2016, 2:56 AM.

Details

Reviewers

mizhka
adrian

Commits

rS302604: bhnd(4): Add bus pass-aware discovery of platform devices (PMU,

Summary

This extends the existing handling of NVRAM core discovery to support
locating additional devices that may be attached either directly as real
cores, or indirectly via ChipCommon (e.g. bhnd_pmu).

When attached as a SoC root bus (as opposed to a bridged WiFi device),
the platform devices may not be attached until later bus passes,
necessitating delayed discovery/initialization.

Test Plan

Verified that the NVRAM device (if supported) is still discovered, and
that NVRAM lookups succeed, e.g.:

bwn0: got macaddr 68:a3:c4:25:fa:5a

Tested on:

BCM4312 (siba, bhndb-attached nvram)
BCM43225 (bcma, chipc-attached nvram)
RT-N53 (mips/bcma, nvram support unimplemented)

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4469
Build 4520: arc lint + arc unit

Event Timeline

landonf updated this revision to Diff 17876.Jun 25 2016, 2:56 AM

landonf retitled this revision from to bhnd(4): Implement generic support for discovery of platform devices (PMU, NVRAM, ChipCommon, etc)..

landonf updated this object.

landonf edited the test plan for this revision. (Show Details)

landonf added reviewers: adrian, mizhka.

Herald added a subscriber: imp. · View Herald TranscriptJun 25 2016, 2:56 AM

Treat bhnd nvram/pmu/chipc devices as valid if they are currently attaching, rather than only after attachment is complete.

as long as it survives make universe, approved!

This revision is now accepted and ready to land.Jul 8 2016, 10:53 PM

Fixed an embarassing copy/paste typo helpfully caught by GCC when testing the universe build.

This revision now requires review to proceed.Jul 10 2016, 12:29 AM

adrian accepted this revision.Jul 10 2016, 12:33 AM

adrian edited edge metadata.

This revision is now accepted and ready to land.Jul 10 2016, 12:33 AM

Closed by commit rS302604: bhnd(4): Add bus pass-aware discovery of platform devices (PMU, (authored by landonf). · Explain WhyJul 12 2016, 2:17 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

dev/

bhnd/

bhnd.h

8 lines

bhnd.c

353 lines

bhnd_subr.c

69 lines

bhndb/

bhndb.c

14 lines

bhndvar.h

14 lines

Commit	Tree	Parents	Author	Summary	Date
48d0162e99d7	d5caa11fbd9b	b5bcdd390a23 f3fcdc1b9534	Landon Fuller	Merge branch 'master' into user/landonf/bhnd/3006_bhnd_platform_devs	Jul 10 2016, 12:26 AM
b5bcdd390a23	91590a8e844f	ef8b4f874aa8	Landon Fuller	Fix copy/paste typo helpfully caught when testing against a universe build.	Jul 10 2016, 12:25 AM
ef8b4f874aa8	2334fa42c16d	39f759c7e2d1	Landon Fuller	Allow lookup of bhnd nvram/pmu/chipc devices during attachment.	Jul 8 2016, 10:37 PM
39f759c7e2d1	244b96785628	48c673181eca d78bae3e3632	Landon Fuller	Merge branch 'master' into user/landonf/bhnd/3006_bhnd_platform_devs	Jul 8 2016, 10:47 PM
48c673181eca	45898d42d6d7	977ed2c84f73 13c308de0c7c	Landon Fuller	Merge branch 'master' into user/landonf/bhnd/3006_bhnd_platform_devs	Jun 26 2016, 9:30 PM
977ed2c84f73	bd5305ce0d57	64f9e13f488d e6b22eb42a51	Landon Fuller	Merge branch 'master' into user/landonf/bhnd/3006_bhnd_platform_devs	Jun 25 2016, 4:50 AM
64f9e13f488d	4f60c9b545c0	861b08e4320b	Landon Fuller	Treat missing devices as warnings, rather than errors.	Jun 25 2016, 2:43 AM
861b08e4320b	eab1c10ca9ba	c7ecae337e78	Landon Fuller	Include the nvram source type when logging a missing NVRAM device.	Jun 24 2016, 11:01 PM
c7ecae337e78	6c49ae2bb7d2	6b87b3bb017d	Landon Fuller	Revert "Pending implementation of PMU support, disable error when PMU device… (Show More…)	Jun 24 2016, 10:18 PM
6b87b3bb017d	d63bca6d8e7f	b2d9a9ddd891	Landon Fuller	Pending implementation of PMU support, disable error when PMU device not found.	Jun 24 2016, 10:10 PM
b2d9a9ddd891	6c49ae2bb7d2	ec34ac01cda6 c69d76183eac	Landon Fuller	Merge branch 'user/landonf/bhnd/3005_bhnd_devinfo' into… (Show More…)	Jun 24 2016, 9:10 PM
c69d76183eac	507b9fff2488	5098dc0daeb5 e1a6d503290c	Landon Fuller	Merge branch 'user/landonf/bhnd/3003_merge_sentry5_bcm' into… (Show More…)	Jun 24 2016, 9:08 PM
e1a6d503290c	6c2e32eb169b	2a831e09e89e be918056dee6	Landon Fuller	Merge branch 'user/landonf/bhnd/3002_chipc_enumeration' into… (Show More…)	Jun 24 2016, 9:08 PM
be918056dee6	214ccc69ee9f	2aedee38aac6 452fe84d9bb6	Landon Fuller	Merge branch 'master' into user/landonf/bhnd/3002_chipc_enumeration	Jun 24 2016, 9:07 PM
2a831e09e89e	6c2e32eb169b	abc69da4a4ea 452fe84d9bb6	Landon Fuller	Merge branch 'master' into user/landonf/bhnd/3003_merge_sentry5_bcm	Jun 24 2016, 8:58 PM
5098dc0daeb5	507b9fff2488	6958adc853b1 452fe84d9bb6	Landon Fuller	Merge branch 'master' into user/landonf/bhnd/3005_bhnd_devinfo	Jun 24 2016, 8:31 PM
ec34ac01cda6	d89bed1927bd	a8c1da44e6d3	Landon Fuller	Fix minor (style(9)) typo in function definition.	Jun 22 2016, 2:45 AM
a8c1da44e6d3	f3d5aac877ea	5b2440af5532	Landon Fuller	Rename bhnd_init_platform_devs() to bhnd_finish_attach().	Jun 22 2016, 2:42 AM
5b2440af5532	3a13f02497b8	70cb73a8f47e	Landon Fuller	Document the BHND_INIT_PLATFORM_PASS bus pass constant.	Jun 22 2016, 2:34 AM
70cb73a8f47e	a937d2bf2305	ea22b953cfe4 6958adc853b1	Landon Fuller	Merge branch 'user/landonf/bhnd/3005_bhnd_devinfo' into… (Show More…)	Jun 22 2016, 2:27 AM
6958adc853b1	76100f105fbd	c0de5d42aa10	Landon Fuller	Drop unused bcma_child_deleted() implementation.	Jun 22 2016, 2:26 AM
ea22b953cfe4	a689318d0ac2	a845998f4efe	Landon Fuller	Handle pass-delayed bhnd(4) attachment initialization on SoCs. (Show More…)	Jun 10 2016, 8:59 PM
a845998f4efe	3532345b10b8	afe7f3746e55	Landon Fuller	Drop unused prototype.	Jun 9 2016, 10:13 PM
afe7f3746e55	c78038851e39	b6c8ebb77040	Landon Fuller	Drop any platform device references in BUS_CHILD_DELETED().	Jun 9 2016, 7:59 PM
b6c8ebb77040	da4fd30f66c9	1d804497a7e2	Landon Fuller	Implement on-demand and post-attach discovery of required chipc/nvram/pmu… (Show More…)	Jun 9 2016, 4:39 PM
1d804497a7e2	bc09ff8350f3	c0de5d42aa10	Landon Fuller	Implement generic support for platform device discovery. (Show More…)	Jun 9 2016, 1:55 AM
c0de5d42aa10	7039e10fe7c4	cb8677908969	Landon Fuller	Delegate BUS_CHILD_DELETED handling to the generic bhnd driver implementation. (Show More…)	Jun 22 2016, 1:46 AM
cb8677908969	c57b513afb98	582cb2d5b587	Landon Fuller	Implement bcma and siba support for the new bhnd_(alloc\|free)_dinfo methods.	Jun 10 2016, 12:45 AM
582cb2d5b587	46c093e36bad	93eb4013e395	Landon Fuller	Implement BUS_ADD_CHILD, ensuring the existence of a valid bcma_devinfo.	Jun 9 2016, 10:12 PM
93eb4013e395	f04a86b0f09c	173d399f5fbd	Landon Fuller	bhnd(4): Add devinfo allocation and child addition methods, modeled on pci_if. (Show More…)	Jun 9 2016, 11:12 PM
173d399f5fbd	45f926bf4995	bcf056a15c6a	Landon Fuller	Replace mips/sentry5 with mips/broadcom. (Show More…)	Jun 22 2016, 12:47 AM
bcf056a15c6a	cad389dc9813	c25477e01e67	Landon Fuller	bhnd(4) chipc child enumeration using the chipc capabilities. (Show More…)	Jun 22 2016, 12:47 AM
abc69da4a4ea	45f926bf4995	982a5e4dd950 2aedee38aac6	Landon Fuller	Merge branch 'user/landonf/bhnd/3002_chipc_enumeration' into… (Show More…)	Jun 21 2016, 9:37 PM
2aedee38aac6	cad389dc9813	a17fd7ba766b c25477e01e67	Landon Fuller	Merge branch 'master' into user/landonf/bhnd/3002_chipc_enumeration	Jun 21 2016, 9:27 PM
a17fd7ba766b	6edd17985ff2	81cce7584343	Landon Fuller	Re-enable layout parsing via the shadow region.	Jun 21 2016, 9:20 PM
982a5e4dd950	417d265da354	e3c644cf99d4 81cce7584343	Landon Fuller	Merge branch 'user/landonf/bhnd/3002_chipc_enumeration' into… (Show More…)	Jun 21 2016, 7:58 PM
81cce7584343	24b7e9b2cdb9	4261f18b416e	Landon Fuller	Revert "Use correct flash shadow RID." (Show More…)	Jun 21 2016, 7:57 PM
4261f18b416e	491319064d8e	b293ee5725ff	Landon Fuller	Use correct flash shadow RID.	Jun 21 2016, 7:54 PM
e3c644cf99d4	417d265da354	6ece43a495a1 b293ee5725ff	Landon Fuller	Merge branch 'user/landonf/bhnd/3002_chipc_enumeration' into… (Show More…)	Jun 21 2016, 7:39 PM
b293ee5725ff	24b7e9b2cdb9	7e38bf09aced	Landon Fuller	Reintegrate chipc_slicer registration.	Jun 21 2016, 7:38 PM
6ece43a495a1	95f5f779cf77	85eaa66e16a8	Landon Fuller	Revert the BCM/BCM_BASE rename in favor of minimal changes to allow existing… (Show More…)	Jun 21 2016, 3:56 AM
85eaa66e16a8	adbc404b5fad	8fb18623fe87	Landon Fuller	Fall back to uart0 if no uart hints are available.	Jun 21 2016, 3:55 AM
8fb18623fe87	2c4df74876bc	476affa43756	Landon Fuller	Drop unused copy-pasted references to sentry5's s5reg.h.	Jun 21 2016, 2:24 AM
476affa43756	9a604f4eb70d	06ffcbb85d85	Landon Fuller	style(9) fixes for non-PMU reset TODO.	Jun 21 2016, 2:23 AM
06ffcbb85d85	ec823596d140	ace2633e1e49	Landon Fuller	Re-introduce CFE memory map debugging using a local BCM_TRACE() macro.	Jun 21 2016, 2:15 AM
ace2633e1e49	6a5be487c6ae	dd9b8ef52633	Landon Fuller	Drop unused copy-pasted reference to sentry5's s5reg.h.	Jun 21 2016, 1:42 AM
dd9b8ef52633	4eb8373e30be	0c9860a7771a 7e38bf09aced	Landon Fuller	Merge branch 'user/landonf/bhnd/3002_chipc_enumeration' into… (Show More…)	Jun 20 2016, 4:37 AM
7e38bf09aced	27bb8c280393	9bc0e45076fe 6828dedaeb9f	Landon Fuller	Merge branch 'master' into user/landonf/bhnd/3002_chipc_enumeration	Jun 20 2016, 4:19 AM
0c9860a7771a	4eb8373e30be	63bfe7d32622	Landon Fuller	Avoid attaching a duplicate uart device directly via device hints; the actual… (Show More…)	Jun 20 2016, 3:59 AM
63bfe7d32622	4d104449f6cd	0a671defdd72 9bc0e45076fe	Landon Fuller	Merge branch 'user/landonf/bhnd/3002_chipc_enumeration' into… (Show More…)	Jun 20 2016, 3:53 AM
0a671defdd72	9c5b5eacc5b5	c09beaf9309a	Landon Fuller	Drop mips/sentry5 in favor of mips/broadcom. (Show More…)	Jun 20 2016, 3:37 AM
c09beaf9309a	e62025fdc4e6	6828dedaeb9f	Landon Fuller	Enable cfi/cfid flash support for SENTRY5 devices.	Jun 17 2016, 1:46 AM
9bc0e45076fe	3ce88533f303	35143804d84d	Landon Fuller	Explicitly enumerate and add all remaining chipc child devices. (Show More…)	Jun 19 2016, 9:40 PM
35143804d84d	7b5eb9e84a99	ff0dab379fe7	Landon Fuller	Avoid exposing default bus method implementations to grandchild devices. (Show More…)	Jun 19 2016, 9:26 PM
ff0dab379fe7	1e4767ffad62	321bd448920a ed393257f098	Landon Fuller	Merge branch 'master' into user/landonf/bhnd/3002_chipc_enumeration	Jun 17 2016, 9:11 PM
321bd448920a	770ff7d039c9	90d56351c6fa	Landon Fuller	Lift port-based child resource configuration out into chipc_set_resource().	Jun 11 2016, 12:53 AM
90d56351c6fa	ac5a02a6f45a	d7aa99b04436 049c16e30089	Landon Fuller	Merge branch 'master' into user/landonf/bhnd/3002_chipc_enumeration	Jun 17 2016, 12:19 AM
d7aa99b04436	2eab77dea1ee	b8c6658ea3c2	Landon Fuller	Fix typo in port/region lookup that just happened to work when the port number… (Show More…)	Jun 12 2016, 12:51 AM
b8c6658ea3c2	e8e1e32b175f	8268d605de15	Landon Fuller	Drop now-unused bhnd_nvram chipc_hint entry.	Jun 12 2016, 12:50 AM
8268d605de15	fa141e1ffbf2	79c78ee733e2	Landon Fuller	Drop parsing of unused chip identification data. (Show More…)	Jun 12 2016, 12:33 AM
79c78ee733e2	eeafba16479c	faf988858c8a	Landon Fuller	Add chipc support for explicitly enumerating children based on the chipc… (Show More…)	Jun 12 2016, 12:13 AM
faf988858c8a	1d91cde04f17	aa44e4a06cfb	Landon Fuller	Fix 0/NULL return value copy-paste error.	Jun 13 2016, 9:50 PM
aa44e4a06cfb	176c6fc61e8a	676e1f5cdfc1	Landon Fuller	siba(4): Adopt a compatible mapping of bhnd(4) port/region identifiers. (Show More…)	Jun 13 2016, 8:29 PM
676e1f5cdfc1	40a02093235b	94874a0297fd	Landon Fuller	Fix reallocation of chipc child resources. (Show More…)	Jun 14 2016, 9:25 PM
94874a0297fd	b5532d6b0c21	736b2b9e0aa6	Landon Fuller	Drop a CHIPC_UNLOCK() accidentally left behind after lifting synchronization… (Show More…)	Jun 14 2016, 9:22 PM
736b2b9e0aa6	feb6e4fdcf72	04076fe55be6	Landon Fuller	Delete all chipc children on attachment failure.	Jun 9 2016, 11:53 PM
04076fe55be6	514659e61d69	a2946b6b1bdf	Landon Fuller	Add missing bhnd_bus_deactivate_resource implementation.	Jun 9 2016, 11:53 PM