Dude you rock! Aside from dev-model, all the changes LGTM.

In D57999#1330057, @ziaee wrote:

Dude you rock! Aside from dev-model, all the changes LGTM.

if the macro is broken, I need to fix it. But I created this macros coz we have these scenarios:

• Online website (freebsd.org, docs.freebsd.org)
• In the books, books in chapters and full book (I forgot about this one :)
• Offline website
• PDFs

In D57999#1330065, @carlavilla wrote:

In D57999#1330057, @ziaee wrote:

Dude you rock! Aside from dev-model, all the changes LGTM.

if the macro is broken, I need to fix it. But I created this macros coz we have these scenarios:

• Online website (freebsd.org, docs.freebsd.org)
• Offline website
• PDFs

It works everywhere else I checked except dev-model.

In D57999#1330069, @ziaee wrote:

In D57999#1330065, @carlavilla wrote:

In D57999#1330057, @ziaee wrote:

Dude you rock! Aside from dev-model, all the changes LGTM.

if the macro is broken, I need to fix it. But I created this macros coz we have these scenarios:

• Online website (freebsd.org, docs.freebsd.org)
• Offline website
• PDFs

It works everywhere else I checked except dev-model.

This links had 2 problems:
[crossref:dev-model[freebsd-send-pr, FreeBSD, 2002D]]

1. The same, as in website - it started and finished by square bracket

and simply disappeared from output (considered as AsciiDoc command).
I fixed this, they appeared, and I saw second problem:

2. The text FreeBSD, 2002D rendered as FreeBSD, everything

after comma were ignored. I removed comma and text is renderd correctly.
This comma is only for refference style, it does not have any special meaning.
With this changes all these links work correctly at least in HTML.

Do you see any problems with them?

P.S. Original article used reference style [FreeBSD, 2002D] long before AsciiDoc
was choosen for FreeBSD documentation, and now [ and ] chars need special treatment
in adoc files, or we are free to rename all these links.

In D57999#1330089, @vladlen wrote:

In D57999#1330069, @ziaee wrote:

In D57999#1330065, @carlavilla wrote:

In D57999#1330057, @ziaee wrote:

Dude you rock! Aside from dev-model, all the changes LGTM.

if the macro is broken, I need to fix it. But I created this macros coz we have these scenarios:

• Online website (freebsd.org, docs.freebsd.org)
• Offline website
• PDFs

It works everywhere else I checked except dev-model.

This links had 2 problems:
[crossref:dev-model[freebsd-send-pr, FreeBSD, 2002D]]

1. The same, as in website - it started and finished by square bracket

and simply disappeared from output (considered as AsciiDoc command).
I fixed this, they appeared, and I saw second problem:

2. The text FreeBSD, 2002D rendered as FreeBSD, everything

after comma were ignored. I removed comma and text is renderd correctly.
This comma is only for refference style, it does not have any special meaning.
With this changes all these links work correctly at least in HTML.

Do you see any problems with them?

P.S. Original article used reference style [FreeBSD, 2002D] long before AsciiDoc
was choosen for FreeBSD documentation, and now [ and ] chars need special treatment
in adoc files, or we are free to rename all these links.

Nah, no problem, proceed as you said 💃

Do you see any problems with them?

It seems you pushed this commit already and it is live on https://docs.freebsd.org/en/books/dev-model/, where the links work. However local build with cd documentation; make, the links do not work, whereas they links do work for local build in handbook. Also, the appearance is wrong for that page because there are padded spaces some places and not other places. Maybe we can do something like \[crossref:dev-model[ref-freebsd-trenches, Lehey 2002]\] for the appearance? I do not know why the links are broken in offline build though.

In D57999#1330255, @ziaee wrote:

Do you see any problems with them?

It seems you pushed this commit already and it is live on https://docs.freebsd.org/en/books/dev-model/, where the links work. However local build with cd documentation; make, the links do not work, whereas they links do work for local build in handbook. Also, the appearance is wrong for that page because there are padded spaces some places and not other places. Maybe we can do something like \[crossref:dev-model[ref-freebsd-trenches, Lehey 2002]\] for the appearance? I do not know why the links are broken in offline build though.

I will check it. I checked it locally with cd documentation; make run and
looked at it in a browser.

I tried using \[ , but the output rendered as \[ literally.

Probably we could change the link style. Links like [1] were used in old
books, and now they are mostly used in scientific articles. Square brackets
are special symbols in AsciiDoc, and we will spend more time fighting with
them than using them comfortably.

In D57999#1330765, @vladlen wrote:

In D57999#1330255, @ziaee wrote:

Do you see any problems with them?

It seems you pushed this commit already and it is live on https://docs.freebsd.org/en/books/dev-model/, where the links work. However local build with cd documentation; make, the links do not work, whereas they links do work for local build in handbook. Also, the appearance is wrong for that page because there are padded spaces some places and not other places. Maybe we can do something like \[crossref:dev-model[ref-freebsd-trenches, Lehey 2002]\] for the appearance? I do not know why the links are broken in offline build though.

I will check it. I checked it locally with cd documentation; make run and
looked at it in a browser.

I tried using \[ , but the output rendered as \[ literally.

Probably we could change the link style. Links like [1] were used in old
books, and now they are mostly used in scientific articles. Square brackets
are special symbols in AsciiDoc, and we will spend more time fighting with
them than using them comfortably.

Yes, as you said, change it.

https://docs.asciidoctor.org/asciidoc/latest/sections/bibliography/

Yes, as you said, change it.

https://docs.asciidoctor.org/asciidoc/latest/sections/bibliography/

I did new patch:
https://reviews.freebsd.org/D58045