Page MenuHomeFreeBSD
Differential D56224

filesystems/gvfs: Add option to use fuser(1) in place of lsof(1)
ClosedPublic
Actions

Authored by madpilot on Apr 2 2026, 4:32 PM.
Tags
None
Referenced Files
F162251782: D56224.diff
Sat, Jul 11, 8:42 AM
Unknown Object (File)
Tue, Jul 7, 5:24 AM
Unknown Object (File)
Tue, Jul 7, 4:19 AM
Unknown Object (File)
Tue, Jul 7, 4:04 AM
Unknown Object (File)
Sun, Jul 5, 5:45 AM
Unknown Object (File)
Sat, Jul 4, 2:23 AM
Unknown Object (File)
Fri, Jul 3, 6:40 AM
Unknown Object (File)
Thu, Jun 25, 4:06 PM
View All 41 Files
Subscribers
dim
fluffy
glebius

Details

Reviewers
fluffy
Group Reviewers
gnome
Commits
R11:90b054438b58: filesystems/gvfs: Use fuser(1) in place of lsof(1) by default
Summary

gvfs has an hard dependency on lsof(1), due to the code using it in just one place to lookup PIDS for programs preventing a removable disk unmount.

lsof(1) is a problematic port, often breaking on head. furthermore, gvfs is depended upon by many desktop environments and programs, causing lsoif to be nstalled on many machines, for just this single internal usage scenario.

We do have fuser(1) in base that provides the required functionality. This patch, also submitted upstream [1] allows us to shed this hard dependency, und use fuser(1) to get the list of pids.

I think this would be a big improvement for many users.

[1] https://gitlab.gnome.org/GNOME/gvfs/-/merge_requests/321

Test Plan

I'm running this patch with XFCE and everything looks fine. Maybe some testing by toher DE users could be useful.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 74363
Build 71246: arc lint + arc unit

Event Timeline

madpilot requested review of this revision.Apr 2 2026, 4:32 PM
madpilot created this revision.
Harbormaster completed remote builds in B71917: Diff 174810.Apr 2 2026, 4:32 PM
glebius added a comment.Apr 2 2026, 4:43 PM

Guido, thanks a lot for working on that!

madpilot updated this revision to Diff 179026.May 31 2026, 2:58 PM

I did get some feedback in the upstream review and updated the upstream patch.

I'm aligning the patch here, and adaping the Makefile to it with this patch update.

Harbormaster completed remote builds in B73588: Diff 179026.May 31 2026, 2:58 PM
madpilot updated this revision to Diff 180881.EditedSun, Jun 28, 7:22 PM

(Sorry, I sent this update by mistake)

Harbormaster completed remote builds in B74363: Diff 180881.Sun, Jun 28, 7:22 PM
madpilot updated this revision to Diff 180882.Sun, Jun 28, 7:25 PM

My patch has been merged upstream (with some changes) [1]

I'm updating this review with a patch reproducing what has been merged.

Since this cahnge is now included upstream and will be in a future
stable release, I'd really like to get approval to update the ports
tree.

Thanks in advance!

[1] https://gitlab.gnome.org/GNOME/gvfs/-/commit/68f26fdfd9fcbe3af4fcdb63b91cdad90037f1c2 and following ones

Harbormaster completed remote builds in B74364: Diff 180882.Sun, Jun 28, 7:25 PM
fluffy accepted this revision.Wed, Jul 1, 11:22 AM
fluffy added a subscriber: fluffy.

LGTM

This revision is now accepted and ready to land.Wed, Jul 1, 11:22 AM
Closed by commit R11:90b054438b58: filesystems/gvfs: Use fuser(1) in place of lsof(1) by default (authored by madpilot). · Explain WhyWed, Jul 1, 4:20 PM
This revision was automatically updated to reflect the committed changes.
madpilot added a commit: R11:90b054438b58: filesystems/gvfs: Use fuser(1) in place of lsof(1) by default.

Revision Contents
Changeset List

PathSize
filesystems/
gvfs/
15 lines
files/
128 lines

Diff 180881

View Options

filesystems/gvfs/Makefile

Loading...
View Options

filesystems/gvfs/files/patch-use_fuser

Loading...