kldxref: Add -m filag to print info about modules in one file
ClosedPublic
Actions

Authored by imp on Jun 27 2026, 1:28 PM.

Details

Reviewers: None
Commits: rG45f9f6ebacff: kldxref: Add -m filag to print info about modules in one file

Summary

kldxref -m <file> will print the same data that the '-d' flag produces,
except restrict the output to one file. This should be the full path to
the file, and the directory name to process is omitted.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 74323
Build 71206: arc lint + arc unit

Event Timeline

imp created this revision.Jun 27 2026, 1:28 PM

Herald added a subscriber: ziaee. · View Herald TranscriptJun 27 2026, 1:28 PM

imp requested review of this revision.Jun 27 2026, 1:28 PM

Harbormaster completed remote builds in B74323: Diff 180812.Jun 27 2026, 1:28 PM

jrtc27 added a subscriber: jrtc27.Jun 27 2026, 1:40 PM

jrtc27 added inline comments.

usr.sbin/kldxref/kldxref.c
796	Isn't < 0 impossible, as that would imply getopt ran off the end of argv? And don't you want to check that no extra arguments were passed for -m, given we skip the fts_open(argv)? That is: if ((module != NULL && argc - optind > 0) \|\| (module == NULL && argc - optind < 1)) or, if you want to be sneaky: if ((module == NULL) == (argc - optind < 1))