science/py-tweedledum: Update to 1.2.0
Needs ReviewPublic
Actions

Authored by des on Thu, Jun 25, 2:56 AM.

Details

Reviewers

hiroo_oikumene.net
yuri

Group Reviewers

Python

Summary

The only changes apart from the version number are a new pep517 build
system and dropping the bundled pybind11 in favor of py-nanobind.

PR: 294633

Test Plan

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 74276
Build 71159: arc lint + arc unit

des requested review of this revision.Thu, Jun 25, 2:56 AM

des created this revision.

des edited the test plan for this revision. (Show Details)Thu, Jun 25, 3:23 AM

version

tweak after testing with py-setuptools-81

Looks good. It is also a good thing that we do not need py-cmake.

This revision is now accepted and ready to land.Tue, Jun 30, 12:00 PM

mat added inline comments.

science/py-tweedledum/Makefile
3–4	You cannot have both PORTVERSION and DISTVERSION, choose one.

science/py-tweedledum/Makefile
3–4	`DISTVERSION` is used by `Mk/Uses/python.mk` and must match the version declared in `pyproject.toml`, but since I'm fetching a specific commit and not an official tag or release I want to include a date in the version. This is the only solution I found that works.