Differential D57754

libnetbsd: Avoid bringing in all of param.h
ClosedPublic
Actions

Authored by markj on Mon, Jun 22, 8:21 PM.

Details

Reviewers

ngie

Group Reviewers

tests

Commits

rG0976744085bc: libnetbsd: Avoid bringing in all of sys/param.h in sys/types.h

Summary

It's okay to hard-code NBBY, the value is unlikely to change. The
pollution makes it harder to import test code from NetBSD since it can
introduce conflicting definitions.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Mon, Jun 22, 8:21 PM

Herald added a subscriber: imp. · View Herald TranscriptMon, Jun 22, 8:21 PM

markj requested review of this revision.Mon, Jun 22, 8:21 PM

Harbormaster completed remote builds in B74117: Diff 180327.Mon, Jun 22, 8:21 PM

ngie accepted this revision.Wed, Jun 24, 7:39 AM

This revision is now accepted and ready to land.Wed, Jun 24, 7:39 AM

What are the conflicting symbols BTW?

In D57754#1325201, @ngie wrote:

What are the conflicting symbols BTW?

I ported some tests which have not been committed yet to NetBSD, they failed to build due to a duplicate definition of MIN().

Closed by commit rG0976744085bc: libnetbsd: Avoid bringing in all of sys/param.h in sys/types.h (authored by markj). · Explain WhyWed, Jun 24, 2:15 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG0976744085bc: libnetbsd: Avoid bringing in all of sys/param.h in sys/types.h.

Revision Contents
Changeset List

Path

Size

lib/

libnetbsd/

sys/

types.h

2 lines

Diff 180530

View Options

libnetbsd: Avoid bringing in all of param.hClosedPublicActions