Differential D6962

bhnd(4): Implement generic support for discovery of platform devices (PMU, NVRAM, ChipCommon, etc).
ClosedPublic
Actions

Authored by landonf on Jun 25 2016, 2:56 AM.

Tags

None

Referenced Files

	F106144378: D6962.diff
	Thu, Dec 26, 3:19 AM

	Unknown Object (File)
	Sat, Dec 14, 10:21 PM

	Unknown Object (File)
	Nov 13 2024, 10:49 AM

	Unknown Object (File)
	Nov 12 2024, 9:52 AM

	Unknown Object (File)
	Nov 12 2024, 7:16 AM

	Unknown Object (File)
	Nov 12 2024, 6:12 AM

	Unknown Object (File)
	Nov 12 2024, 4:52 AM

	Unknown Object (File)
	Nov 12 2024, 4:13 AM

View All 61 Files

Subscribers

Details

Reviewers

mizhka
adrian

Commits

rS302604: bhnd(4): Add bus pass-aware discovery of platform devices (PMU,

Summary

This extends the existing handling of NVRAM core discovery to support
locating additional devices that may be attached either directly as real
cores, or indirectly via ChipCommon (e.g. bhnd_pmu).

When attached as a SoC root bus (as opposed to a bridged WiFi device),
the platform devices may not be attached until later bus passes,
necessitating delayed discovery/initialization.

Test Plan

Verified that the NVRAM device (if supported) is still discovered, and
that NVRAM lookups succeed, e.g.:

bwn0: got macaddr 68:a3:c4:25:fa:5a

Tested on:

BCM4312 (siba, bhndb-attached nvram)
BCM43225 (bcma, chipc-attached nvram)
RT-N53 (mips/bcma, nvram support unimplemented)

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4340
Build 4385: arc lint + arc unit

Event Timeline

landonf updated this revision to Diff 17876.Jun 25 2016, 2:56 AM

landonf retitled this revision from to bhnd(4): Implement generic support for discovery of platform devices (PMU, NVRAM, ChipCommon, etc)..

landonf updated this object.

landonf edited the test plan for this revision. (Show Details)

landonf added reviewers: adrian, mizhka.

Herald added a subscriber: imp. · View Herald TranscriptJun 25 2016, 2:56 AM

Treat bhnd nvram/pmu/chipc devices as valid if they are currently attaching, rather than only after attachment is complete.

as long as it survives make universe, approved!

This revision is now accepted and ready to land.Jul 8 2016, 10:53 PM

Fixed an embarassing copy/paste typo helpfully caught by GCC when testing the universe build.

This revision now requires review to proceed.Jul 10 2016, 12:29 AM

adrian accepted this revision.Jul 10 2016, 12:33 AM

adrian edited edge metadata.

This revision is now accepted and ready to land.Jul 10 2016, 12:33 AM

Closed by commit rS302604: bhnd(4): Add bus pass-aware discovery of platform devices (PMU, (authored by landonf). · Explain WhyJul 12 2016, 2:17 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

dev/

bhnd/

8 lines

353 lines

69 lines

bhndb/

14 lines

14 lines

Diff 17876

sys/dev/bhnd/bhnd.h

Loading...

sys/dev/bhnd/bhnd.c

Loading...

sys/dev/bhnd/bhnd_subr.c

Loading...

sys/dev/bhnd/bhndb/bhndb.c

Loading...

sys/dev/bhnd/bhndvar.h

Loading...