Page MenuHomeFreeBSD

libjail: fix fetching mac.label for multiple jails
Needs ReviewPublic

Authored by kevans on May 27 2026, 6:50 PM.
Tags
None
Referenced Files
F167013159: D57280.diff
Tue, Aug 18, 2:21 PM
Unknown Object (File)
Sat, Aug 8, 3:26 PM
Unknown Object (File)
Fri, Aug 7, 2:19 PM
Unknown Object (File)
Thu, Aug 6, 12:03 AM
Unknown Object (File)
Sun, Aug 2, 3:39 AM
Unknown Object (File)
Sat, Aug 1, 5:44 AM
Unknown Object (File)
Tue, Jul 21, 6:30 PM
Unknown Object (File)
Tue, Jul 21, 4:30 PM
Subscribers

Details

Reviewers
ivy
Group Reviewers
Jails
Summary

When doing a basic jls -n, jls(8) will jailparam_get() the mac.label
for every jail on the system using the same set of jailparams, and thus
the same jp_value. We only init the mac_t the first time, so the first
jail would populate it with ? from /etc/mac.conf and the resulting
jail_get(2) would clobber it with the empty string, then a second jail
would try to pass the empty string to the kernel and fail because it
must have a non-zero length.

Fix it by invoking jps_get() every time. Drop some comments to note
that jps_get() will be invoked with zero || garbage from previous call,
and be sure that we don't leak our previous mac_t. There aren't any
other jps_get implementations at this time, so this shouldn't cause any
unexpected problems.

Reported by: ivy

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 73486
Build 70369: arc lint + arc unit

Event Timeline

jamie added a subscriber: jamie.

The key point is "there aren't any other jps_get implementations." So it's all yours :-)