Page MenuHomeFreeBSD

net80211: fix LOR in ieee80211_ff_node_cleanup()
ClosedPublic

Authored by avos on Jun 24 2016, 5:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 7, 12:15 PM
Unknown Object (File)
Wed, May 6, 2:31 AM
Unknown Object (File)
Thu, Apr 30, 6:20 PM
Unknown Object (File)
Wed, Apr 29, 1:20 PM
Unknown Object (File)
Tue, Apr 28, 12:32 PM
Unknown Object (File)
Thu, Apr 23, 5:38 AM
Unknown Object (File)
Thu, Apr 23, 2:08 AM
Unknown Object (File)
Sun, Apr 19, 1:23 PM
Subscribers

Details

Summary

Add new lock for stageq (part of ieee80211_superg structure) and ni_tx_superg (part of ieee80211_node structure); drop com_lock protection where it is used.
While here, drop duplicate OPACKETS counter incrementation.

ni_tx_ampdu is not protected with it (however, it is also used without locking in other places; probably, it requires some other solution to be thread-safe).

Since this change breaks KBI, it will not be merged into 11.0-RELEASE.

Test Plan

Tested with RTL8188CUS (AP) and RTL8188EU (STA).

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

avos retitled this revision from to net80211: fix LOR in ieee80211_ff_node_cleanup().
avos updated this object.
avos edited the test plan for this revision. (Show Details)
avos added a reviewer: adrian.
avos set the repository for this revision to rS FreeBSD src repository - subversion.
This revision was automatically updated to reflect the committed changes.