ping6: convert receive loop from pselect(2) to ppoll(2)
ClosedPublic
Actions

Authored by oshogbo on Apr 29 2026, 10:34 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Jul 15, 7:20 AM

	Unknown Object (File)
	Wed, Jul 15, 7:20 AM

	Unknown Object (File)
	Mon, Jul 13, 2:26 PM

	Unknown Object (File)
	Sat, Jul 11, 2:47 AM

	Unknown Object (File)
	Wed, Jul 8, 8:08 AM

	Unknown Object (File)
	Mon, Jul 6, 4:43 AM

	Unknown Object (File)
	Sun, Jul 5, 7:40 PM

	Unknown Object (File)
	Sun, Jul 5, 12:52 PM

View All 43 Files

Subscribers

imp

Details

Reviewers

markj

Commits

rG1d0410fb349f: ping6: convert receive loop from pselect(2) to ppoll(2)

Summary

pselect(2) might overflow if the desciptor number is above
FD_SETSIZE and silently corrupt the stack. Switch to ppoll(2) so
the receive socket fd is no longer constrained by FD_SETSIZE.

Reported by: Joshua Rogers

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 72644
Build 69527: arc lint + arc unit

Event Timeline

oshogbo created this revision.Apr 29 2026, 10:34 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 29 2026, 10:34 PM

oshogbo requested review of this revision.Apr 29 2026, 10:34 PM

Harbormaster completed remote builds in B72644: Diff 176830.Apr 29 2026, 10:34 PM

oshogbo added a reviewer: markj.Apr 29 2026, 10:34 PM

markj accepted this revision.May 3 2026, 11:53 PM

This revision is now accepted and ready to land.May 3 2026, 11:53 PM

Closed by commit rG1d0410fb349f: ping6: convert receive loop from pselect(2) to ppoll(2) (authored by oshogbo). · Explain WhyMay 21 2026, 6:14 AM

This revision was automatically updated to reflect the committed changes.

oshogbo added a commit: rG1d0410fb349f: ping6: convert receive loop from pselect(2) to ppoll(2).

Revision Contents
Changeset List

Path

Size

sbin/

ping/

ping6.c

10 lines

Diff 176830

View Options

ping6: convert receive loop from pselect(2) to ppoll(2)ClosedPublicActions