rtlbtfw: handle partial reads when loading firmware
AbandonedPublic
Actions

Authored by longros on Apr 18 2026, 11:44 AM.

Details

Reviewers

Summary

Loop until all bytes are read or a real error occurs, instead of
assuming a single read() returns the entire file. Retry on EINTR
and break on EOF. Use intmax_t casts in the error message to
match off_t portably.

Signed-off-by: Christos Longros

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 72321
Build 69204: arc lint + arc unit

Event Timeline

longros created this revision.Apr 18 2026, 11:44 AM

Herald added a subscriber: imp. · View Herald TranscriptApr 18 2026, 11:44 AM

longros requested review of this revision.Apr 18 2026, 11:44 AM

Harbormaster completed remote builds in B72321: Diff 175829.Apr 18 2026, 11:44 AM

longros added a reviewer: wulf.Apr 18 2026, 11:45 AM

Although it looks good, replacing read() with mmap() -> memcpy() -> munmap() sequence would make code simpler and cleaner

I committed mmap()-based changes. See: https://cgit.freebsd.org/src/commit/?id=87ed6840a0a6320295f6abb43a987d20ae126cf7

In D56500#1296504, @wulf wrote:

I committed mmap()-based changes. See: https://cgit.freebsd.org/src/commit/?id=87ed6840a0a6320295f6abb43a987d20ae126cf7

I was working on the changes, but thanks for implementing them :)

longros abandoned this revision.Apr 24 2026, 3:49 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

bluetooth/

rtlbtfw/

rtlbt_fw.c

30 lines

Diff 175829

View Options

usr.sbin/bluetooth/rtlbtfw/rtlbt_fw.c

rtlbtfw: handle partial reads when loading firmwareAbandonedPublicActions