Page MenuHomeFreeBSD
Differential D6728

Do not access pv_table array for fictitious pages ...
ClosedPublic
Actions

Authored by kib on Jun 4 2016, 5:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 17, 11:21 AM
Unknown Object (File)
Sep 28 2024, 2:08 PM
Unknown Object (File)
Sep 23 2024, 7:15 PM
Unknown Object (File)
Sep 23 2024, 1:10 PM
Unknown Object (File)
Sep 19 2024, 8:08 AM
Unknown Object (File)
Sep 18 2024, 10:07 AM
Unknown Object (File)
Sep 17 2024, 8:54 PM
Unknown Object (File)
Sep 7 2024, 7:01 PM
View All 50 Files
Subscribers
imp

Details

Reviewers
alc
Summary

... since the array does not cover the dynamically registered ficititious ranges.

Reported and tested by: Michael Butler <imb@protected-networks.net>

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

kib updated this revision to Diff 17309.Jun 4 2016, 5:59 PM
kib retitled this revision from to Do not access pv_table array for fictitious pages ....
kib updated this object.
kib edited the test plan for this revision. (Show Details)
kib added a reviewer: alc.
kib set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added a subscriber: imp. · View Herald TranscriptJun 4 2016, 5:59 PM
kib updated this object.Jun 9 2016, 2:32 AM
alc edited edge metadata.Jun 10 2016, 11:08 PM

I have one suggestion about the implementation. Instead of adding new conditionals, create a global, dummy "struct md_page" and conditionally initialize pvh to point to this dummy struct rather than pa_to_pvh(...) before acquiring the pv list lock.

kib updated this revision to Diff 17504.Jun 11 2016, 4:08 AM
kib edited edge metadata.

Use dummy struct md_page for checking generation number of the (nonexistent) superpage pv list for fictitious managed pages.

alc added inline comments.Jun 11 2016, 4:28 AM
sys/amd64/amd64/pmap.c
3928–3929

If we statically initialize pv_dummy's pv_list field to an empty state, then this "if" statement can be eliminated.

5749–5750

Same here.

5881–5882

Here I think that the "(m->flags & PG_FICTITIOUS) != 0" can be deleted, but the rest should remain.

6198–6199

Same here as the first and second cases.

kib updated this revision to Diff 17505.Jun 11 2016, 4:43 AM

Utilize empty pv_list of the md_dummy placeholder to avoid more conditionals.

alc accepted this revision.Jun 11 2016, 4:49 AM
alc edited edge metadata.
This revision is now accepted and ready to land.Jun 11 2016, 4:49 AM
kib closed this revision.Jun 27 2016, 6:42 PM

Revision Contents
Changeset List

PathSize
sys/
amd64/
amd64/
25 lines

Diff 17505

View Options

sys/amd64/amd64/pmap.c

Loading...