Page MenuHomeFreeBSD
Differential D56229

tunefs: Fix alignment warning on arm64
ClosedPublic
Actions

Authored by des on Apr 2 2026, 8:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, May 25, 9:22 PM
Unknown Object (File)
Mon, May 25, 9:12 PM
Unknown Object (File)
Sun, May 24, 9:10 AM
Unknown Object (File)
Wed, May 20, 8:31 PM
Unknown Object (File)
Wed, May 20, 7:52 AM
Unknown Object (File)
Sun, May 17, 3:31 PM
Unknown Object (File)
Fri, May 15, 4:02 AM
Unknown Object (File)
Tue, Apr 28, 5:52 PM
View All 23 Files
Subscribers
imp

Details

Reviewers
bakul_iitbombay.org
Commits
rG616f47f176c3: tunefs: Fix alignment warning on arm64
Summary

MFC after: 1 week
Reported by: bakul
Fixes: c5e79c7e93dd ("tunefs: Don't lower WARNS")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des created this revision.Apr 2 2026, 8:53 PM
Herald added a subscriber: imp. · View Herald TranscriptApr 2 2026, 8:53 PM
des requested review of this revision.Apr 2 2026, 8:53 PM
Harbormaster completed remote builds in B71924: Diff 174819.Apr 2 2026, 8:53 PM
bakul_iitbombay.org accepted this revision.Apr 2 2026, 9:12 PM

Not sure why the compiler complained since it should know that indirbuf is a local, and it should know its own alignment logic for locals!

This revision is now accepted and ready to land.Apr 2 2026, 9:12 PM
Closed by commit rG616f47f176c3: tunefs: Fix alignment warning on arm64 (authored by des). · Explain WhyApr 2 2026, 9:25 PM
This revision was automatically updated to reflect the committed changes.
des added a commit: rG616f47f176c3: tunefs: Fix alignment warning on arm64.
des added a comment.Apr 2 2026, 9:39 PM
In D56229#1286514, @bakul_iitbombay.org wrote:

Not sure why the compiler complained since it should know that indirbuf is a local, and it should know its own alignment logic for locals!

This falls in the category of “probably ok with current compilers but technically not allowed”, I'll have a better patch tomorrow but at least the build is no longer broken.

des mentioned this in rG83a0bced4ef0: tunefs: Don't lower WARNS.Apr 4 2026, 8:59 AM
des mentioned this in rG1fcaefce1e19: tunefs: Don't lower WARNS.

Revision Contents
Changeset List

PathSize
sbin/
tunefs/
2 lines

Diff 174820

View Options

sbin/tunefs/tunefs.c

Loading...