Differential D56229

tunefs: Fix alignment warning on arm64
ClosedPublic
Actions

Authored by des on Thu, Apr 2, 8:53 PM.

Tags

None

Referenced Files

	F150717075: D56229.diff
	Fri, Apr 3, 2:15 PM

Subscribers

Details

Reviewers

bakul_iitbombay.org

Commits

rG616f47f176c3: tunefs: Fix alignment warning on arm64

Summary

MFC after: 1 week
Reported by: bakul
Fixes: c5e79c7e93dd ("tunefs: Don't lower WARNS")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

des created this revision.Thu, Apr 2, 8:53 PM

Herald added a subscriber: imp. · View Herald TranscriptThu, Apr 2, 8:53 PM

des requested review of this revision.Thu, Apr 2, 8:53 PM

Harbormaster completed remote builds in B71924: Diff 174819.Thu, Apr 2, 8:53 PM

Not sure why the compiler complained since it should know that indirbuf is a local, and it should know its own alignment logic for locals!

This revision is now accepted and ready to land.Thu, Apr 2, 9:12 PM

Closed by commit rG616f47f176c3: tunefs: Fix alignment warning on arm64 (authored by des). · Explain WhyThu, Apr 2, 9:25 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rG616f47f176c3: tunefs: Fix alignment warning on arm64.

In D56229#1286514, @bakul_iitbombay.org wrote:

Not sure why the compiler complained since it should know that indirbuf is a local, and it should know its own alignment logic for locals!

This falls in the category of “probably ok with current compilers but technically not allowed”, I'll have a better patch tomorrow but at least the build is no longer broken.

Revision Contents
Changeset List

Path

Size

sbin/

tunefs/

2 lines

Diff 174820

sbin/tunefs/tunefs.c

Loading...